Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable universal links support for QR code login #23953

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Jan 7, 2025

Changes:

  • Disable universal links support for QR code login. You'll now have to scan the code using the app.
  • Fix an issue with the confirmation screen being shown multiple times
ScreenRecording_01-07-2025.10-46-51_1.MP4

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Login label Jan 7, 2025
@kean kean added this to the 25.7 milestone Jan 7, 2025
@@ -48,6 +49,9 @@ extension QRLoginScanningCoordinator {
}

func didScanToken(_ token: QRLoginToken) {
guard !didHandleToken else { return }
Copy link
Contributor Author

@kean kean Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't reply on camera.stop because it has a race condition:

    func stop() {
        sessionQueue.async { [weak self] in
            self?.session?.stopRunning()
        }

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 7, 2025

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23953-011b671
Version25.6
Bundle IDorg.wordpress.alpha
Commit011b671
App Center BuildWPiOS - One-Offs #11295
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 7, 2025

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23953-011b671
Version25.6
Bundle IDcom.jetpack.alpha
Commit011b671
App Center Buildjetpack-installable-builds #10330
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean merged commit 4b41387 into christmas-feature-branch Jan 7, 2025
0 of 2 checks passed
@kean kean deleted the fix/disable-qr-code-universal-links branch January 7, 2025 18:08
@kean kean mentioned this pull request Jan 7, 2025
14 tasks
@kean kean changed the title Disable universal links support for QR code login Disable universal links support for QR code login Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants