Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Branch 25.7 #23923

Open
wants to merge 214 commits into
base: trunk
Choose a base branch
from
Open

Feature Branch 25.7 #23923

wants to merge 214 commits into from

Conversation

kean
Copy link
Contributor

@kean kean commented Dec 24, 2024

This PR contains changes targeting 25.7. The focus is on decluttering and bug fixing. Each change was created as separate PR and can be reviewed individually:

  1. Replace WPImageViewController with LightboxViewController #23922
  2. Remove ImageLoader and ImageDimensionFetcher #23924
  3. Remove CachedAnimatedImageView and related types #23925
  4. Remove AnimatedImageCache and related types #23926
  5. Remove AlamofireImage #23927
  6. Add ImagePrefetcher (and swift-collection) and integrate in Reader #23928
  7. Add ImageSize #23929
  8. Fix an issue with blogging reminders prompt not being shown after publishing a new post #23930
  9. Fix transitions in Blogging Reminders flow, improve accessibility, add close buttons #23931
  10. Fix an issue with compliance popover not dismissing for self-hosted site #23932
  11. Remove BottomSheetViewController (use more fluid native sheets) #23933
  12. Add Share action to site link context menu on dashboard #23935
  13. Fix layout issues in Privacy Settings section of App Settings #23936
  14. Rename WordPressMedia to AsyncImageKit #23937
  15. Move AsyncImageView to AsyncImageKit #23938
  16. Cleanup MediaHost initializers #23939
  17. Fix incorrect chevron icons direction in RTL languages #23940
  18. Fix an issue with clear navigation bar background in revision browser #23941
  19. Fix an issue with comments being lost on request failure #23942
  20. Fix an issue with Referrers in Stats showing invalid icons #23943
  21. Integrate zoom transitions in Theme browser #23945
  22. Fix tint color in wpios #23946
  23. Integrate zoom transitions in Reader #23947
  24. Enable toolbar hiding on iPad too #23948
  25. Fix an issue with Publisize options appearing in the prepublishing sheet for sites that don't support it #23949
  26. Fix an issue with site icons cropped in share extensions #23950
  27. Disable universal links support for QR code login #23953
  28. Enable fast deceleration for filters on the Discover tab #23954
  29. Show selected filter in the Discover navigation bar #23956
  30. Add scroll-to-top button to Reader streams #23957
  31. Improve featured image flow #23962
  32. Fix an issue with wrong cover images appearing in Reader #23914
  33. Fix an issue with non-stable order in Posts and Pages in stats #23915
  34. Fix an issue with a missing "Mark as Unread" button in the More menu #23917
  35. Add missing social sharing icons #23918
  36. Add context menus and previews for sites in Reader #23964
  37. Fix an issue with fullscreen button in reply view clipped by the notch #23965
  38. Remove "Lazy Images" Jetpack option #23966

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Dec 24, 2024
@kean kean added this to the 25.7 milestone Dec 24, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 24, 2024

4 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.7. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 24, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23923-094a68f
Version25.6
Bundle IDorg.wordpress.alpha
Commit094a68f
App Center BuildWPiOS - One-Offs #11332
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 24, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23923-094a68f
Version25.6
Bundle IDcom.jetpack.alpha
Commit094a68f
App Center Buildjetpack-installable-builds #10364
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

kean and others added 30 commits January 9, 2025 10:55
* Fix an issue with wrong cover images appearing in Reader

* Update release notes

* Update release notes
* Fix an issue with non-stable order in Posts and Pages in stats

* Update release notes

* Update release notes
…23917)

* Add missing toggle read/unread button

* Show read status in the list

* Update release notes

* Update release notes
* Add missing social sharing icons

* Update release notes

* Update release notes
* Fix l10n typo

* Add Unsubscribe context menu to Reader sidebar sites

* Extract ReaderSiteFavoriteButton

* Move actions to ReaderSidebarSubscriptionCell

* Extract ReaderSubscriptionContextMenu and add Share

* Add Notification Settings and Copy Link buttons

* Add context menu for sites in Subscriptions view

* Add previews

* Fix notification settings sometimes being clipped on iPad

* Fix layout in ReaderSubscriptionCel actions
#23965)

* Fix an issue with fullscreen button in reply view clipped by the notch

* Update release notes
* Remove lazy loading:

* Add error handling

* Update release notes

* Update WordPressKit (has lazy-load fix)

* Update release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants