Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve @woocommerce/experimental.Text to suppress build warnings. #561

Merged
merged 1 commit into from
May 6, 2021
Merged

Resolve @woocommerce/experimental.Text to suppress build warnings. #561

merged 1 commit into from
May 6, 2021

Conversation

tomalec
Copy link
Member

@tomalec tomalec commented May 6, 2021

Changes proposed in this Pull Request:

Resolve @woocommerce/experimental.Text to suppress build warnings._

Fixes build warnings introduced in #537 (comment).

Screenshots:

image

Detailed test instructions:

  1. npm install
  2. npm run start
  3. No warnings should be shown. At least none

Changelog Note:

Fix @woocommerce/experimental.Text

@tomalec tomalec self-assigned this May 6, 2021
@tomalec tomalec requested a review from a team May 6, 2021 13:15
ecgan
ecgan approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@ecgan ecgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, working good, no more bunch of warnings in console! 🎉 👍

@tomalec tomalec merged commit 476489e into trunk May 6, 2021
@tomalec tomalec deleted the fix/woocommerce/experimental-warnings branch May 6, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecgan ecgan ecgan approved these changes

Assignees

@tomalec tomalec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomalec @ecgan