Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tax rate setup to the Settings page #2749

Merged
merged 10 commits into from
Jan 6, 2025

Add the confirmation notification after the tax rate setting is succe…

fdae02a
Select commit
Loading
Failed to load commit list.
Merged

Move tax rate setup to the Settings page #2749

Add the confirmation notification after the tax rate setting is succe…
fdae02a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2025 in 0s

63.8% (+0.3%) compared to 6462683

View this Pull Request on Codecov

63.8% (+0.3%) compared to 6462683

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.8%. Comparing base (6462683) to head (fdae02a).
Report is 3 commits behind head on feature/shipping-improvements.

Files with missing lines Patch % Lines
.../free-listings/setup-free-listings/form-content.js 0.0% 0 Missing and 1 partial ⚠️
...ponents/free-listings/setup-free-listings/index.js 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feature/shipping-improvements   #2749     +/-   ##
===============================================================
+ Coverage                           63.5%   63.8%   +0.3%     
===============================================================
  Files                                337     334      -3     
  Lines                               5196    5159     -37     
  Branches                            1274    1262     -12     
===============================================================
- Hits                                3300    3290     -10     
+ Misses                              1723    1699     -24     
+ Partials                             173     170      -3     
Files with missing lines Coverage Δ
...listings/configure-product-listings/checkErrors.js 100.0% <100.0%> (ø)
...es/onboarding/setup-stepper/saved-setup-stepper.js 87.2% <ø> (ø)
.../free-listings/setup-free-listings/form-content.js 6.7% <0.0%> (+0.8%) ⬆️
...ponents/free-listings/setup-free-listings/index.js 6.3% <50.0%> (+0.2%) ⬆️

... and 2 files with indirect coverage changes