-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tax rate setup to the Settings page #2749
base: feature/shipping-improvements
Are you sure you want to change the base?
Conversation
… and the related components and functions.
…d the related components and functions.
…ble options during submission.
…per and below its card.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/shipping-improvements #2749 +/- ##
===============================================================
+ Coverage 63.5% 63.8% +0.3%
===============================================================
Files 337 334 -3
Lines 5196 5159 -37
Branches 1274 1262 -12
===============================================================
- Hits 3300 3290 -10
+ Misses 1723 1699 -24
+ Partials 173 170 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
WDYT about adding a confirmation message as feedback when the Setting save is completed. Screen.Recording.2025-01-03.at.13.37.01.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eason9487 for working on this. I didn't found any blocker so far. Just a recommendation about adding a message after saving taxes setting. Not sure if this was already discussed with Design. In any case not a strong blocker for me and can be done also in further PRs
- Tested the Taxes Section is not shown in Edit Free listings ✅
- Tested the Edit Free listings still work and can be saved ✅
- Tested the Taxes Section is not shown in Settings when neither US is the store base address nor a audience target country ✅
- Tested the Taxes Section is shown in Settings when either US is the store base address or a audience target country ✅
- Tested you can save the taxes and it calls the API endpoints ✅
- UI general checks
- Code & Tests checks
- Additional Onboarding check
).not.toBeVisible(); | ||
} ); | ||
|
||
test( 'Update the setting', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test( 'Update the setting', async () => { | |
test( 'Should show the setup when selling to the US and can update the setting', async () => { |
Changes proposed in this Pull Request:
Project thread: pcTzPl-2Cf-p2
This PR implements the 📌 Move tax setting to main setting page task of the project.
💡 Update for
src/Tracking/README.md
will be done by the conjunction PR for the feature branch.Screenshots:
Detailed test instructions:
wc/gla/mc/settings
wc/gla/mc/settings/sync
Changelog entry