Migrate to stylelint 15 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did I miss something crucial here? |
yayuyokitano
force-pushed
the
master
branch
from
ecf844d to
b9b04a6
Compare
inverse
reviewed
Sep 21, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "stylelint-config-web-scrobbler", | |||
| "version": "0.2.0", | |||
| "name": "@web-scrobbler/stylelint-config", | |||
There was a problem hiding this comment.
I guess we should update the readme too with this? Or shall we do it after once it's published on NPM?
There was a problem hiding this comment.
Readme is bundled with the package iirc, so better change it first
|
Is this readme modification good? |
|
Seems legit to me. CI is already setup so should just be tagging a release 👍 Just need to make sure the package version is correct :) |
inverse
approved these changes
Sep 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be green with my branch of web scrobbler.
Let's get this rolling once and for all.
A lot of deprecated properties included but still works.
Fixing the deprecations requires work elsewhere.