Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/locale selector #374

Merged
merged 10 commits into from
Apr 22, 2021
Merged

Fix/locale selector #374

merged 10 commits into from
Apr 22, 2021

Conversation

vitorflg
Copy link
Contributor

What problem is this solving?

The context for this change is in the #prod-muji-eu channel.

  1. On a binding selector change, the block selector not works without toggling it.
  2. On a locale selector change, the block selector not works until the page is reloaded.

How should this be manually tested?

https://www.loom.com/share/0ea28c9573754baeb8d7d96e3ded5156

https://vitorflg--muji.myvtex.com/admin/cms/site-editor

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

It already adds the changes of this PR(Hide query string from the iframe top bar): #368

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 25, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vitorflg vitorflg force-pushed the fix/locale-selector branch from 7071c73 to 6908459 Compare April 19, 2021 15:37
@vitorflg vitorflg force-pushed the fix/locale-selector branch from b82c0ec to 87cabec Compare April 22, 2021 08:58
@vitorflg vitorflg merged commit ae80d08 into master Apr 22, 2021
@vitorflg vitorflg deleted the fix/locale-selector branch April 22, 2021 09:05
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Apr 22, 2021

Your PR has been merged! App is being published. 🚀
Version 4.40.0 → 4.40.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants