Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom callback param to the localesChanged event #602

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

vitorflg
Copy link
Contributor

@vitorflg vitorflg commented Feb 25, 2021

The context for this change is in the #prod-muji-eu channel.

What does this PR do? *

As the title says, it adds a new param to the localesChanged event handler for a custom callback, considering that could be other options besides a page reload.

How to test it? *

https://www.loom.com/share/0ea28c9573754baeb8d7d96e3ded5156

https://vitorflg--muji.myvtex.com/admin/cms/site-editor

Describe alternatives you've considered, if any. *

X

Related to / Depends on *

It's a PR that support another one -> vtex-apps/admin-pages#374

@vitorflg vitorflg requested a review from lbebber February 25, 2021 23:49
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 25, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Feb 25, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@vitorflg vitorflg force-pushed the event-custom-callback branch from 8b078a2 to 3fc6ec0 Compare March 10, 2021 20:13
@vitorflg vitorflg merged commit 9f7951b into master Mar 12, 2021
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 12, 2021

Your PR has been merged! App is being published. 🚀
Version 8.127.0 → 8.128.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants