-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the HiFiAC codec #762
base: master
Are you sure you want to change the base?
Conversation
This is a proprietary codec and it's uncertain who can use it, and under what conditions. At this point, Opus is stable and a suitable replacement.
The following links are available:
build (macOS-latest, full) build (windows-latest, full) |
I agree, though generally I sense we should probably improve the Opus controls a bit before doing this so that people at least have some tuning in how they want to handle things? |
if we have permissions to use it, it seems like we could keep this? if opus becomes the default and is configurable, that’s great, but we might have situations where the hifi codec is necessary? |
To me this is a no-brainer. We are an open-source project and if someone builds the interface, they essentially infringe the copyright of that codec. |
@@ -1343,8 +1343,8 @@ | |||
"name": "codec_preference_order", | |||
"label": "Audio Codec Preference Order", | |||
"help": "List of codec names in order of preferred usage", | |||
"placeholder": "opus, hifiAC, zlib, pcm", | |||
"default": "opus,hifiAC,zlib,pcm", | |||
"placeholder": "opus, zlib, pcm", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"placeholder": "opus, zlib, pcm", | |
"placeholder": "opus, zlib, pcm", |
Dev meeting: this is waiting on opus performance improvements |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello! Is this still an issue? |
This is a proprietary codec and it's uncertain who can use it, and
under what conditions. At this point, Opus is stable and a suitable
replacement.