Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vircadia is still being build with hifiAC #508

Open
JulianGro opened this issue Jul 5, 2020 · 5 comments · May be fixed by #762
Open

Vircadia is still being build with hifiAC #508

JulianGro opened this issue Jul 5, 2020 · 5 comments · May be fixed by #762
Labels
confirmed The bug has been successfully reproduced. stale Issue / PR has not had activity

Comments

@JulianGro
Copy link
Contributor

Since we already broke compatibility with High Fidelity, there is little reason to keep hifiAC if we are worried about permission or even just including proprietary software in our open source project.
@daleglass daleglass added the confirmed The bug has been successfully reproduced. label Aug 1, 2020
@daleglass
Copy link
Contributor

Agreed with this during the dev meeting.

The codec is proprietary, and while Kalila has an agreement with HiFi the company, that probably doesn't apply to any forks.

We'll look into adding a parameter to cmake that's disabled by default, so that it can still be built if somebody specifically wants it.

@JulianGro JulianGro linked a pull request Oct 3, 2020 that will close this issue
Open
@JulianGro JulianGro linked a pull request Dec 22, 2020 that will close this issue
Remove the HiFiAC codec #762
Open
@stale
Copy link

stale bot commented Mar 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue / PR has not had activity label Mar 27, 2021
@digisomni digisomni removed the stale Issue / PR has not had activity label Apr 19, 2021
@stale
Copy link

stale bot commented Oct 16, 2021

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Oct 16, 2021
@JulianGro
Copy link
Contributor Author

Yes 😠

@stale stale bot removed the stale Issue / PR has not had activity label Oct 16, 2021
@stale
Copy link

stale bot commented Apr 14, 2022

Hello! Is this still an issue?

@stale stale bot added the stale Issue / PR has not had activity label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed The bug has been successfully reproduced. stale Issue / PR has not had activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the HiFiAC codec daleglass/vircadia
3 participants
@JulianGro @daleglass @digisomni