Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add busco #6

Merged
merged 57 commits into from
Jan 31, 2024
Merged

Add busco #6

merged 57 commits into from
Jan 31, 2024

Conversation

dorien-er
Copy link
Contributor

@dorien-er dorien-er commented Jan 25, 2024 •
edited
Loading

Description

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@dorien-er dorien-er requested a review from rcannood January 26, 2024 10:58
rcannood
rcannood requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! Please take a look at my suggestions.

Also, could you add an entry to the changelog?

src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
src/busco/test_data/protein.fasta Outdated Show resolved Hide resolved
src/busco/script.sh Outdated Show resolved Hide resolved
src/busco/script.sh Outdated Show resolved Hide resolved
src/busco/script.sh Outdated Show resolved Hide resolved
src/busco/version.sh Outdated Show resolved Hide resolved
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
@dorien-er dorien-er marked this pull request as ready for review January 26, 2024 16:14
rcannood
rcannood reviewed Jan 30, 2024
View reviewed changes
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
rcannood
rcannood requested changes Jan 30, 2024
View reviewed changes
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
src/busco/script.sh Outdated Show resolved Hide resolved
src/busco/script.sh Outdated Show resolved Hide resolved
rcannood
rcannood reviewed Jan 30, 2024
View reviewed changes
src/busco/busco/test.sh Outdated Show resolved Hide resolved
dorien-er and others added 15 commits January 30, 2024 20:39
rcannood
rcannood requested changes Jan 31, 2024
View reviewed changes
src/busco/test.sh Outdated Show resolved Hide resolved
src/busco/config.vsh.yaml Outdated Show resolved Hide resolved
@dorien-er @rcannood
Update src/busco/config.vsh.yaml
1edbcb2 
Co-authored-by: Robrecht Cannoodt <[email protected]>
rcannood
rcannood reviewed Jan 31, 2024
View reviewed changes
src/busco/test.sh Show resolved Hide resolved
src/busco/test.sh Show resolved Hide resolved
rcannood
rcannood approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 88f7b92 into viash-hub:main Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorien-er @rcannood