feat(ci): add options to disable liquid rendering and run pre-check script #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cript This commit adds two new options to the Jekyll link checker workflow: 1. `add-no-render-with-liquid`: When set to "true", this option adds `render_with_liquid: false` to a set of files (*.md, *.java, *.sd, services.xml, hosts.xml, deployment.xml) before building the site. This is useful for preventing liquid rendering in certain files. 2. `pre-check-script`: Allows specifying a path to a script that should be run before the link checking step. This can be used to perform additional checks or modifications before the main link checking process. These changes provide more flexibility and control over the build and link checking process, allowing users to customize the workflow to their specific needs.
esolitos
force-pushed
the
remove-redirect-files-before-link-check
branch
11 times, most recently
from
0d6dbc1 to
b8f7de1
Compare
kkraune
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This commit adds a few new options to the Jekyll link checker workflow:
add-no-render-with-liquidWhen set to "true", the workflow will include
render_with_liquid: falseto all the predefined files (*.md, *.java, *.sd, services.xml, hosts.xml, deployment.xml) before building the site.This is useful for preventing liquid rendering in certain files.
pre-check-scriptAllows specifying a path to a script that should be run before the link checking step.
This can be used to perform additional checks or modifications before the main link checking process.
build-plugins:Allows to specify a list of plugins which will be run before the build.
Why
These changes provide more flexibility. Specifically they were part of getting the workflow to work in the repo https://github.com/vespa-engine/sample-apps
Additional info
Related PR: