Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate workflow to link check for Jekyll installable to GitHub Actions - MERGEOK #32148

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

glebashnik
Copy link
Contributor

@glebashnik glebashnik commented Aug 14, 2024

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

What

Adds a new workflow to check links in Jekyll generated site.
The workflow is triggered either manually or on a daily schedule.

Why

Part of the process of retiring Screwdriver as CI/CD runner.

Additional Info

See successful test run:
https://github.com/vespa-engine/vespa/actions/runs/10388245270/job/28763467543?pr=32148

@glebashnik glebashnik requested a review from esolitos August 14, 2024 13:18
@glebashnik glebashnik changed the title Glebashnik/gh action link check Link check for Jekyll site Aug 14, 2024
Copy link
Contributor

@esolitos esolitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be worth re-using the workflow here: https://github.com/vespa-engine/gh-actions/blob/main/.github/workflows/jekyll-link-checker.yml

Mind that there's an open PR to review on this workflow:
vespa-engine/gh-actions#6

@glebashnik glebashnik changed the title Link check for Jekyll site GitHub Actions to link check for Jekyll site Aug 14, 2024
@glebashnik glebashnik changed the title GitHub Actions to link check for Jekyll site GitHub Actions workflow to link check for Jekyll site Aug 14, 2024
@esolitos esolitos self-assigned this Aug 14, 2024
@esolitos esolitos force-pushed the glebashnik/gh-action-link-check branch 2 times, most recently from fc67242 to 88c9079 Compare August 15, 2024 07:04
@esolitos esolitos changed the title GitHub Actions workflow to link check for Jekyll site migrate workflow to link check for Jekyll installable to GitHub Actions Aug 15, 2024
@esolitos esolitos requested a review from bjormel August 15, 2024 07:05
@esolitos
Copy link
Contributor

I swapped out the custom workflow with the shared-reusable one which we built.

@esolitos esolitos changed the title migrate workflow to link check for Jekyll installable to GitHub Actions migrate workflow to link check for Jekyll installable to GitHub Actions - MERGEOK Aug 15, 2024
@glebashnik glebashnik merged commit b198dce into master Aug 16, 2024
3 checks passed
@glebashnik glebashnik deleted the glebashnik/gh-action-link-check branch August 16, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants