Java: Add managers layer to client #717

Yury-Fridlyand · 2023-12-21T20:47:00Z

Part 2 of client implementation. See part 1 in #670

This PR includes changes for:

Manager layer for java client: ConnectionManager and CommandManager
RequestBuilder
Refactor for Platform - class was split into two: Platform and ThreadPoolAllocator
Refactor on CallbackDispatcher for better callback id handling
RedisValueResolver

Proposed usage in Client class:

package babushka.api;

import babushka.connectors.handlers.CallbackDispatcher;
import babushka.connectors.handlers.ChannelHandler;
import babushka.ffi.resolvers.SocketListenerResolver;
import babushka.managers.CommandManager;
import babushka.managers.ConnectionManager;
import java.util.concurrent.atomic.AtomicBoolean;

public class Client {

  public Client() {

    AtomicBoolean connectionStatus = new AtomicBoolean(false);

    CallbackDispatcher callbackDispatcher = new CallbackDispatcher(connectionStatus);
    ChannelHandler channelHandler =
        new ChannelHandler(callbackDispatcher, SocketListenerResolver.getSocket());
    var connectionManager = new ConnectionManager(channelHandler, connectionStatus);
    var commandManager = new CommandManager(channelHandler);
  }
}

And Awaiter:

package babushka.api;

import java.util.concurrent.CancellationException;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;

public class Awaiter {
  private static final long DEFAULT_TIMEOUT_MILLISECONDS = 30000;

  /** Get the future result with default timeout. */
  public static <T> T await(CompletableFuture<T> future) {
    return await(future, DEFAULT_TIMEOUT_MILLISECONDS);
  }

  /** Get the future result with given timeout in ms. */
  public static <T> T await(CompletableFuture<T> future, long timeout) {
    try {
      return future.get(timeout, TimeUnit.MILLISECONDS);
    } catch (ExecutionException e) {
      throw new RuntimeException(e.getMessage(), e.getCause());
    } catch (InterruptedException e) {
      // TODO should shutdown the client service
      if (Thread.currentThread().isInterrupted()) {
        // restore interrupt
        Thread.interrupted();
      }
      throw new RuntimeException("The thread was interrupted", e);
    } catch (TimeoutException e) {
      throw new RuntimeException("Request timed out", e);
    } catch (CancellationException e) {
      throw new RuntimeException("Request was cancelled", e);
    }
  }
}

Signed-off-by: Yury-Fridlyand <[email protected]>

* Managers Signed-off-by: Yury-Fridlyand <[email protected]> * Refactor Signed-off-by: Yury-Fridlyand <[email protected]> * Split `ClientState` and `Platform`. Signed-off-by: Yury-Fridlyand <[email protected]> * Refactor Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR feedback. Signed-off-by: Yury-Fridlyand <[email protected]> * Minor fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Typo fix. Signed-off-by: Yury-Fridlyand <[email protected]> * Refactor Signed-off-by: Yury-Fridlyand <[email protected]> * javadocs Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>

…ient_part2 Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto · 2023-12-22T17:01:01Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+  }
+
+  /** Check a response received from Glide. */
+  private boolean checkGlideRsResponse(Response response) {


The error handling is very similar to extractValueFromGlideRsResponse in the CommandManager. I have combined these in the following PR.

why do this in the next PR and not here?

yep it shouldn't be duplicated

so i'm not reviewing of this function

Sorry. To reduce the size of the PR to review, we're doing this in stages. We have an API-layer PR that deals with this function properly.
And we handle errors in the API side, rather than in the backend.

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto · 2023-12-22T23:45:34Z

java/client/src/main/java/glide/models/RequestBuilder.java

+import redis_request.RedisRequestOuterClass.Routes;
+import redis_request.RedisRequestOuterClass.SimpleRoutes;
+
+public class RequestBuilder {


This class is being merged with the Connection and CommandManagers by San.

This class is being merged with the Connection and CommandManagers by San.

How long will it take? If it'll be done soon, maybe just update this PR with the change.

That'll make this PR really big :(
I'll raise the PR now so you can review them side-by-side. How about that?

This code will be merged into ConnectionManager.
see: https://github.com/aws/babushka/pull/737/files#diff-83c7a94dda6cdf7ffac0c085bf9abbff0fd3a3baf753e5043be7f21fdf48733d

shachlanAmazon

initial comments

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

shachlanAmazon · 2023-12-24T07:08:45Z

java/client/src/main/java/glide/models/RequestBuilder.java

+    }
+
+    return RedisRequest.newBuilder()
+        .setSingleCommand( // set command


why are these comments needed? they just repeat the name of the called function.

I'd suggest that we postpone review of this file, as it gets merged into the ConnectionManager https://github.com/aws/babushka/pull/737/files#diff-83c7a94dda6cdf7ffac0c085bf9abbff0fd3a3baf753e5043be7f21fdf48733d

shachlanAmazon · 2023-12-24T07:18:41Z

java/client/src/main/java/glide/managers/CommandManager.java

+    // TODO commented out due to #710 https://github.com/aws/babushka/issues/710
+    //      empty response means a successful command
+    // throw new IllegalStateException("A malformed response received: " + response.toString());
+    return "OK";


this should be a null response, not OK.

Yes. Out of scope for now. We have an incoming API with typing PR coming that properly handles the valueFromPointer.

I don't see why return "OK"; -> return null; out of scope, but 🤷 just add a TODO

shachlanAmazon · 2023-12-24T07:18:57Z

java/client/src/main/java/glide/managers/CommandManager.java

+    }
+    // TODO commented out due to #710 https://github.com/aws/babushka/issues/710
+    //      empty response means a successful command
+    // throw new IllegalStateException("A malformed response received: " + response.toString());


please remove commented out code.

👍
We have an incoming API with typing PR coming that properly handles the valueFromPointer response.

shachlanAmazon · 2023-12-24T07:21:41Z

java/client/src/main/java/glide/managers/CommandManager.java

+  private CompletableFuture<String> submitNewRequest(RequestType command, List<String> args) {
+    // TODO this explicitly uses ForkJoin thread pool. May be we should use another one.
+    return CompletableFuture.supplyAsync(
+            () -> channel.write(RequestBuilder.prepareRedisRequest(command, args), true))


if channel.write returns a completable future, why do you need CompletableFuture.supplyAsync?

shachlanAmazon · 2023-12-24T07:32:42Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+  }
+
+  /** Check a response received from Glide. */
+  private boolean checkGlideRsResponse(Response response) {


why do this in the next PR and not here?

shachlanAmazon · 2023-12-24T07:33:34Z

java/client/src/main/java/glide/models/RequestBuilder.java

+import redis_request.RedisRequestOuterClass.Routes;
+import redis_request.RedisRequestOuterClass.SimpleRoutes;
+
+public class RequestBuilder {


This class is being merged with the Connection and CommandManagers by San.

How long will it take? If it'll be done soon, maybe just update this PR with the change.

java/client/src/main/java/glide/connectors/resources/ThreadPoolAllocator.java

java/client/src/main/java/glide/ffi/resolvers/RedisValueResolver.java

shachlanAmazon · 2023-12-24T08:01:14Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

 public class CallbackDispatcher {
-  /** Unique request ID (callback ID). Thread-safe. */
+
+  /** Client connection status needed to distinguish connection request. */


This comment only explains where this is used, not what does the value mean.

barshaul · 2023-12-25T13:14:33Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

    var future = new CompletableFuture<Response>();
+    Integer callbackId = connectionStatus.get() ? freeRequestIds.poll() : CONNECTION_PROMISE_ID;


I'm still not following why do we need to have a reserved ID for the connection promise.
The client creation call shouldn't return to the user until the connection is set with the connection configurations. So, why can't we just assign the first callback index to the connection info? we don't need to save this index to a later stage - we won't configure the connection again in the client lifetime.

barshaul · 2023-12-25T13:16:06Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

-    int callbackId = response.getCallbackIdx();
-    if (callbackId == 0) {
-      connectionPromise.completeAsync(() -> response);
+    // A connection response doesn't contain a callback id


the rust core does return it with the callback index it was sent with. If java doesn't support 0 in the callback index, you can simply start all callback indexes from 1

barshaul · 2023-12-25T13:17:49Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

-      responses.get(callbackId).completeAsync(() -> response);
-      responses.remove(callbackId);
+      // TODO: log an error.
+      // probably a response was received after shutdown or `registerRequest` call was missing


We should throw an error in this case and close the client

This really should only ever happen if the client is shutting down. In extreme cases, there are no threads available to call compete... and this operation is cancelled.

barshaul · 2023-12-25T13:30:03Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

-      connectionPromise.completeAsync(() -> response);
+    // A connection response doesn't contain a callback id
+    int callbackId = connectionStatus.get() ? response.getCallbackIdx() : CONNECTION_PROMISE_ID;
+    CompletableFuture<Response> future = responses.get(callbackId);


you can use remove here

barshaul · 2023-12-25T13:36:01Z

java/client/src/main/java/glide/managers/CommandManager.java

+   * Check response and extract data from it.
+   *
+   * @param response A response received from rust core lib
+   * @return A String from the Redis RESP2 response, or Ok. Otherwise, returns null


We're using RESP3 by default, but it can be changed, lets remove the protocol from the comment

barshaul · 2023-12-25T13:40:15Z

java/client/src/main/java/glide/managers/CommandManager.java

+              "%s: %s",
+              response.getRequestError().getType(), response.getRequestError().getMessage()));
+    } else if (response.hasClosingError()) {
+      CompletableFuture.runAsync(channel::close);


Does channel::close closes the socket and all open futures? We need to call shutdownGracefully to close the socket and all open futures when we get a closing error

In the following PR, we're handling the closeError at a higher level, which has access to close the open requests.

then please add a TODO to close the channel on closeError

java/client/src/main/java/glide/managers/CommandManager.java

barshaul · 2023-12-25T13:59:59Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+   *
+   * @param host Server address
+   * @param port Server port
+   * @param useSsl true if communication with the server or cluster should use Transport Level


useSsl => useTLS

ignore this. We have an incoming PR with configuration that properly names these variables as per node/python.

fixed in 4cd6642

why merge the wrong names in this PR? This isn't something that increases the size of the PR.

barshaul · 2023-12-25T14:04:47Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+   * @param port Server port
+   * @param useSsl true if communication with the server or cluster should use Transport Level
+   *     Security
+   * @param clusterMode true if REDIS instance runs in the cluster mode


true if the client is used for connecting to a Redis Cluster.

fixed in 4cd6642

where's 4cd6642?

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

acarbonetto · 2023-12-27T23:48:52Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

-      responses.get(callbackId).completeAsync(() -> response);
-      responses.remove(callbackId);
+      // TODO: log an error.
+      // probably a response was received after shutdown or `registerRequest` call was missing


This really should only ever happen if the client is shutting down. In extreme cases, there are no threads available to call compete... and this operation is cancelled.

java/client/src/main/java/glide/connectors/resources/ThreadPoolAllocator.java

java/client/src/main/java/glide/ffi/resolvers/RedisValueResolver.java

java/client/src/main/java/glide/managers/CommandManager.java

acarbonetto · 2023-12-28T00:04:05Z

java/client/src/main/java/glide/managers/CommandManager.java

+              "%s: %s",
+              response.getRequestError().getType(), response.getRequestError().getMessage()));
+    } else if (response.hasClosingError()) {
+      CompletableFuture.runAsync(channel::close);


In the following PR, we're handling the closeError at a higher level, which has access to close the open requests.

acarbonetto · 2023-12-28T00:04:41Z

java/client/src/main/java/glide/managers/CommandManager.java

+    }
+    // TODO commented out due to #710 https://github.com/aws/babushka/issues/710
+    //      empty response means a successful command
+    // throw new IllegalStateException("A malformed response received: " + response.toString());


👍
We have an incoming API with typing PR coming that properly handles the valueFromPointer response.

acarbonetto · 2023-12-28T00:05:40Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+   *
+   * @param host Server address
+   * @param port Server port
+   * @param useSsl true if communication with the server or cluster should use Transport Level


ignore this. We have an incoming PR with configuration that properly names these variables as per node/python.

acarbonetto · 2023-12-28T00:07:28Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+  }
+
+  /** Check a response received from Glide. */
+  private boolean checkGlideRsResponse(Response response) {


Sorry. To reduce the size of the PR to review, we're doing this in stages. We have an API-layer PR that deals with this function properly.
And we handle errors in the API side, rather than in the backend.

acarbonetto · 2023-12-28T00:08:19Z

java/client/src/main/java/glide/models/RequestBuilder.java

+import redis_request.RedisRequestOuterClass.Routes;
+import redis_request.RedisRequestOuterClass.SimpleRoutes;
+
+public class RequestBuilder {


That'll make this PR really big :(
I'll raise the PR now so you can review them side-by-side. How about that?

Signed-off-by: Andrew Carbonetto <[email protected]>

acarbonetto · 2024-01-02T19:47:49Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

+   * submits connection requests until a successful connection response is returned and the status
+   * changes to true. The callback dispatcher then submits command requests.
+   */
+  private final AtomicBoolean isConnectedStatus;


remove this - isConnectedStatus is no longer needed.

jonathanl-bq

Left a few nit comments. Approved if those are fixed as well as other remaining comments.

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

Signed-off-by: Andrew Carbonetto <[email protected]>

shachlanAmazon

please fix comments / mark all future work with a TODO.

shachlanAmazon · 2024-01-02T17:44:08Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+   * @param port Server port
+   * @param useSsl true if communication with the server or cluster should use Transport Level
+   *     Security
+   * @param clusterMode true if REDIS instance runs in the cluster mode


where's 4cd6642?

shachlanAmazon · 2024-01-02T17:44:39Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+   *
+   * @param host Server address
+   * @param port Server port
+   * @param useSsl true if communication with the server or cluster should use Transport Level


why merge the wrong names in this PR? This isn't something that increases the size of the PR.

shachlanAmazon · 2024-01-02T17:45:13Z

java/client/src/main/java/glide/managers/CommandManager.java

+    // TODO commented out due to #710 https://github.com/aws/babushka/issues/710
+    //      empty response means a successful command
+    // throw new IllegalStateException("A malformed response received: " + response.toString());
+    return "OK";


I don't see why return "OK"; -> return null; out of scope, but 🤷 just add a TODO

shachlanAmazon · 2024-01-03T12:22:32Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

    responses.put(callbackId, future);
    return Pair.of(callbackId, future);
  }

  public CompletableFuture<Response> registerConnection() {
-    return connectionPromise;
+    var res = registerRequest();
+    return res.getValue();


so you created a future, you saved it in responses, and now you ignore the key? how will you remove this future from responses?

Connection requests are always defined with key callbackIdx of 0.
When the connection completes, we call completeRequest and the response will be removed from the responses.

why build in this assumption?

Discussed this in-person, and it doesn't look like our connection requests accept a idx so we have to assume that the callback idx will be 0.

shachlanAmazon · 2024-01-03T12:58:43Z

java/client/src/main/java/glide/connectors/resources/ThreadPoolAllocator.java

+   * Thread pools supplied to <em>Netty</em> to perform all async IO.<br>
+   * Map key is supposed to be pool name + thread count as a string concat product.
+   */
+  private static final Map<String, EventLoopGroup> groups = new ConcurrentHashMap<>();


in which scenario will we need more than a ELG? will the user be able to register ELGs with different names?

Yes. We will accept user-provided ELG in the configurations.

TODO added in 0327a84

shachlanAmazon · 2024-01-03T13:12:04Z

java/client/src/main/java/glide/managers/CommandManager.java

+   * @param key The key name
+   * @param value The value to set
+   */
+  public CompletableFuture<String> set(String key, String value) {


how would you like to track the missing options field? TODO, issue?

I can add a TODO here.

TODO added in 0327a84

shachlanAmazon · 2024-01-03T13:13:06Z

java/client/src/main/java/glide/managers/CommandManager.java

+              "%s: %s",
+              response.getRequestError().getType(), response.getRequestError().getMessage()));
+    } else if (response.hasClosingError()) {
+      CompletableFuture.runAsync(channel::close);


then please add a TODO to close the channel on closeError

shachlanAmazon · 2024-01-03T13:13:53Z

java/client/src/main/java/glide/managers/CommandManager.java

+   */
+  private String extractValueFromGlideRsResponse(Response response) {
+    if (response.hasRequestError()) {
+      // TODO do we need to support different types of exceptions and distinguish them by type?


you can remove the question mark :)
yes, you need to throw the same exceptions as other clients.

TODO updated in 0327a84

shachlanAmazon · 2024-01-03T13:17:59Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+ * responses from the same socket channel handler.
+ */
+@RequiredArgsConstructor
+public class ConnectionManager {


this looks like a single-use object - why is it an instantiated object and not a static function?

Interesting idea. Static classes are harder to test, and when we add configuration this class will grow.

That being said, if we want to really drive home the 'single use' responsibility of the object (i.e. make a connection and then forget about this) we should make this a static class with static-only methods.

I'm going to differ this comment to the follow-up PR.
We will make it into a static class there if necessary.

@acarbonetto doesn't have to be in the next PR. can be in a separate PR (small is fast!)

shachlanAmazon · 2024-01-03T13:34:57Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+  /** Check a response received from Glide. */
+  private Void checkGlideRsResponse(Response response) {
+    if (response.hasRequestError()) {
+      // TODO do we need to support different types of exceptions and distinguish them by type?


here you should expect only closing errors.

TODO updated in 0327a84

Signed-off-by: Andrew Carbonetto <[email protected]>

acarbonetto · 2024-01-03T16:50:37Z

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java

    responses.put(callbackId, future);
    return Pair.of(callbackId, future);
  }

  public CompletableFuture<Response> registerConnection() {
-    return connectionPromise;
+    var res = registerRequest();
+    return res.getValue();


Discussed this in-person, and it doesn't look like our connection requests accept a idx so we have to assume that the callback idx will be 0.

acarbonetto · 2024-01-03T16:53:19Z

java/client/src/main/java/glide/managers/ConnectionManager.java

+ * responses from the same socket channel handler.
+ */
+@RequiredArgsConstructor
+public class ConnectionManager {


I'm going to differ this comment to the follow-up PR.
We will make it into a static class there if necessary.

Yury-Fridlyand added 9 commits December 15, 2023 16:16

Add java client connection layer.

dfc0ea2

Signed-off-by: Yury-Fridlyand <[email protected]>

Optimize protobuf and netty integration.

ce166b1

Signed-off-by: Yury-Fridlyand <[email protected]>

Rework how we open Channel.

e429be9

Signed-off-by: Yury-Fridlyand <[email protected]>

More TODOs for the god of TODOs.

708293f

Signed-off-by: Yury-Fridlyand <[email protected]>

Rename CallbackManager to CallbackDispatcher.

12dcaba

Signed-off-by: Yury-Fridlyand <[email protected]>

Merge remote-tracking branch 'upstream/main' into java/integ_yuryf_cl…

fbd0366

…ient_part2 Signed-off-by: Yury-Fridlyand <[email protected]>

submodule update

579c53c

Signed-off-by: Yury-Fridlyand <[email protected]>

typo fix

c78169b

Signed-off-by: Yury-Fridlyand <[email protected]>

Yury-Fridlyand added the java issues and fixes related to the java client label Dec 21, 2023

Yury-Fridlyand requested review from barshaul, asafpamzn and shachlanAmazon December 21, 2023 20:47

Yury-Fridlyand requested a review from a team as a code owner December 21, 2023 20:47

Yury-Fridlyand mentioned this pull request Dec 22, 2023

Java: add testing tools and few tests #718

Closed

Yury-Fridlyand added 2 commits December 21, 2023 17:53

Renaming

7d1ba35

Signed-off-by: Yury-Fridlyand <[email protected]>

Restore javadocs.

7c5fc69

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto approved these changes Dec 22, 2023

View reviewed changes

Optimize callback ID allocation.

cb0f6c4

Signed-off-by: Yury-Fridlyand <[email protected]>

acarbonetto reviewed Dec 22, 2023

View reviewed changes

Yury-Fridlyand mentioned this pull request Dec 23, 2023

Java: API layer with RedisClient and basic commands Bit-Quill/valkey-glide#46

Merged

shachlanAmazon reviewed Dec 24, 2023

View reviewed changes

barshaul reviewed Dec 25, 2023

View reviewed changes

java/client/src/main/java/glide/managers/CommandManager.java Show resolved Hide resolved

barshaul reviewed Dec 25, 2023

View reviewed changes

acarbonetto reviewed Dec 28, 2023

View reviewed changes

acarbonetto mentioned this pull request Dec 28, 2023

[Closing...] Java: API layer with RedisClient and basic commands #734

Closed

acarbonetto added 2 commits December 28, 2023 11:12

Optimize code for review comments

74a6ce0

Signed-off-by: Andrew Carbonetto <[email protected]>

Get before increment when getting a new callback id; add javadocs

6dcad76

Signed-off-by: Andrew Carbonetto <[email protected]>

This was referenced Dec 29, 2023

Java: API layer with RedisClient #737

Merged

[Can be deleted] Java: API layer with single commands (base, string, & void) Bit-Quill/valkey-glide#49

Closed

Update connectionManager arguments

4cd6642

Signed-off-by: Andrew Carbonetto <[email protected]>

acarbonetto reviewed Jan 2, 2024

View reviewed changes

jonathanl-bq approved these changes Jan 3, 2024

View reviewed changes

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java Outdated Show resolved Hide resolved

java/client/src/main/java/glide/connectors/handlers/CallbackDispatcher.java Outdated Show resolved Hide resolved

acarbonetto added 2 commits January 2, 2024 16:06

Remove connection status from the connection manager

596462c

Signed-off-by: Andrew Carbonetto <[email protected]>

Clean up code comments

448c6e5

Signed-off-by: Andrew Carbonetto <[email protected]>

shachlanAmazon approved these changes Jan 3, 2024

View reviewed changes

Add TODOs

0327a84

Signed-off-by: Andrew Carbonetto <[email protected]>

acarbonetto approved these changes Jan 3, 2024

View reviewed changes

acarbonetto merged commit 29d9bb0 into valkey-io:main Jan 3, 2024
3 checks passed

acarbonetto deleted the java/integ_yuryf_client_part2 branch January 3, 2024 16:55

This was referenced Jan 11, 2024

Java - Add RedisException return to connection/command response handling Bit-Quill/valkey-glide#57

Merged

Java - Add RedisException return to connection/command response handl… #788

Merged

		var future = new CompletableFuture<Response>();
		Integer callbackId = connectionStatus.get() ? freeRequestIds.poll() : CONNECTION_PROMISE_ID;

Java: Add managers layer to client #717

Java: Add managers layer to client #717

Conversation

Yury-Fridlyand commented Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shachlanAmazon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto Jan 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto Jan 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonathanl-bq left a comment

Choose a reason for hiding this comment

shachlanAmazon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto Jan 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto Jan 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acarbonetto Jan 3, 2024 • edited Loading

Yury-Fridlyand commented Dec 21, 2023 •

edited

Loading

acarbonetto Jan 2, 2024 •

edited

Loading

acarbonetto Jan 2, 2024 •

edited

Loading

acarbonetto Jan 3, 2024 •

edited

Loading

acarbonetto Jan 3, 2024 •

edited

Loading

acarbonetto Jan 3, 2024 •

edited

Loading