forked from valkey-io/valkey-glide
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Can be deleted] Java: API layer with single commands (base, string, & void) #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 29, 2023
jonathanl-bq
reviewed
Jan 3, 2024
acarbonetto
force-pushed
the
java/integ_acarbo_refactor_api_createclient
branch
from
January 3, 2024 22:35
09fd5c7
to
617ab3e
Compare
acarbonetto
force-pushed
the
java/integ_acarbo_refactor_api_submitRequests
branch
from
January 3, 2024 23:34
6d82f84
to
9db449c
Compare
acarbonetto
commented
Jan 5, 2024
import response.ResponseOuterClass; | ||
import response.ResponseOuterClass.Response; | ||
|
||
public class ConnectionManagerTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate of ConnectionManagerTest in managers.ConnectionManagerTest
acarbonetto
force-pushed
the
java/integ_acarbo_refactor_api_submitRequests
branch
from
January 5, 2024 13:19
e4dda03
to
dd40a72
Compare
acarbonetto
commented
Jan 8, 2024
if (value instanceof String) { | ||
return (String) value; | ||
} | ||
throw new RedisException( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider return type: maybe ClosingException? and we close the client?
acarbonetto
force-pushed
the
java/integ_acarbo_refactor_api_submitRequests
branch
from
January 10, 2024 21:23
4b83ad4
to
cb1966e
Compare
acarbonetto
changed the base branch from
java/integ_acarbo_refactor_api_createclient
to
main
January 11, 2024 21:01
* Add java client connection layer. Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: SanHalacogluImproving <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
* Add java client connection layer. Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: SanHalacogluImproving <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/integ_acarbo_refactor_api_submitRequests
branch
from
January 11, 2024 21:38
cb1966e
to
cada9b7
Compare
acarbonetto
changed the title
Java: API layer with single commands (base, string, & void)
[Can be deleted] Java: API layer with single commands (base, string, & void)
Jan 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on valkey-io#717.
Issue #, if available:
API layer for: valkey-io#589
Description of changes:
In this PR, we're adding an API layer that creates a RedisClient using a RedisConfiguration.
Introduces the get & set & customCommand calls that allow a user to use the RedisClient.
This PR ensures that the type returned from the get/set/customCommand is correct for the type. A request using Exec returns a generic instead.
Out of Scope
Use cases
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.