Fix Build CI exit value #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Werrorが適切に落ちるようになった |
| @@ -164,3 +164,8 @@ jobs: | |||
| -efm="%E%f:%l:%c: error: %m" \ | |||
| -efm="%C%m" \ | |||
| < clang_tidy.log | |||
|
|
|||
| - name: build failed | |||
| if: steps.build.outcome == 'failure' | |||
There was a problem hiding this comment.
[zatsu] へー，こんなんあったんだね
https://docs.github.com/ja/actions/learn-github-actions/contexts
There was a problem hiding this comment.
https://docs.github.com/ja/actions/learn-github-actions/contexts#steps-context
です．conclusionとoutcomeで使い分けられる．
|
良さそうなので，ビルド通らないところこちらで直します． |
sksat
force-pushed
the
hotfix/build-ci-exit
branch
from
32f0e47 to
785bcce
Compare
|
rebaseしました |
meltingrabbit
force-pushed
the
hotfix/build-ci-exit
branch
from
ae89dd7 to
85184cb
Compare
meltingrabbit
force-pushed
the
hotfix/build-ci-exit
branch
from
85184cb to
4718517
Compare
meltingrabbit
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
ビルドが落ちていてもビルドCIが通ってしまうことがあるのを修正
Issue/PR
詳細
(特にWerrorにおいて)PRでの変更外でのワーニングをreviewdogが無視してしまうためビルドCIが意図したものになっていなかったのを修正