Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version (v3.5.0): やり直し #246

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Update version (v3.5.0): やり直し #246

merged 1 commit into from
Feb 8, 2022

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Feb 8, 2022 •
edited by sksat
Loading

概要

Update version (v3.5.0): やり直し

Issue/PR

詳細

CIがよろしくなく，main updateでCIが通らなかったことの対応が終わったので，バージョンを上げ直す

検証結果

CIと既存のテストが全て通ればOK

@meltingrabbit meltingrabbit added the priority::medium priority medium label Feb 8, 2022
@meltingrabbit meltingrabbit self-assigned this Feb 8, 2022
sksat
sksat approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@sksat sksat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIが渋かっただけですし，修正して通ってるのでapproveです．

@meltingrabbit
Copy link
Collaborator Author

テスト通し中．通ったらマージします．（30分ぐらいかかる）

@meltingrabbit meltingrabbit mentioned this pull request Feb 8, 2022
Merged
@meltingrabbit
Copy link
Collaborator Author

とおったね

@meltingrabbit meltingrabbit merged commit c3f1729 into develop Feb 8, 2022
@meltingrabbit meltingrabbit deleted the feature/update_version_3-5-0_again branch February 8, 2022 03:37
@meltingrabbit meltingrabbit mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksat sksat sksat approved these changes

@chutaro chutaro Awaiting requested review from chutaro

@yngyu yngyu Awaiting requested review from yngyu

Assignees

@meltingrabbit meltingrabbit

Labels
priority::medium priority medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @sksat