Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Over Image Capture Script #39

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Port Over Image Capture Script #39

merged 5 commits into from
Nov 24, 2024

Conversation

jbrhm
Copy link
Contributor

@jbrhm jbrhm commented Nov 7, 2024

Summary

Closes #31

What features did you add, bugs did you fix, etc?
I ported the zed image capture script from ros1 to ros2

Did you add documentation to the wiki?

No

How was this code tested?

Ran it with the zed and made sure it processed everything properly

Did you test this in sim?

No

Did you test this on the rover?

No

Did you add unit tests?

Yes/No (If not explain why not)

@jbrhm jbrhm self-assigned this Nov 7, 2024
Copy link
Contributor

@Crypt1cG Crypt1cG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scripts/image_capture.py Outdated Show resolved Hide resolved
@jbrhm jbrhm merged commit c5ca25b into main Nov 24, 2024
1 check passed
@jbrhm jbrhm deleted the JRA/image-capture branch November 24, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add zed image capture script to ROS2
4 participants