Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed topic names for ZED wrapper and Sim #19

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Fixed topic names for ZED wrapper and Sim #19

merged 4 commits into from
Oct 1, 2024

Conversation

jbrhm
Copy link
Contributor

@jbrhm jbrhm commented Oct 1, 2024

Summary

Closes #17

What features did you add, bugs did you fix, etc?
Fixed topic conflicts between ZED Wrapper and Sim

Did you add documentation to the wiki?

No, there is already documentation

How was this code tested?

I tested the Object Detector in Sim and on the ZED making sure that it was able to identify objects in both

Did you test this in sim?

Yes

Did you test this on the rover?

Yes

Did you add unit tests?

No, this is just bug fixes not new functionality

@jbrhm jbrhm requested a review from alisonryckman October 1, 2024 15:31
@jbrhm jbrhm self-assigned this Oct 1, 2024
Copy link
Contributor

@alisonryckman alisonryckman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbrhm jbrhm merged commit 2bb7799 into main Oct 1, 2024
1 check passed
@jbrhm jbrhm deleted the JRA/ZED-Naming branch October 1, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming consistency for zed topics
2 participants