Fix shellcheck in style.sh

ansible/roles/build/tasks/main.yml

@@ -71,6 +71,7 @@
       - curl
       - unzip
       - rsync
+      - shellcheck
       - python3-pip
       - python3-dev
       - python3-venv

starter_project/autonomy/format.sh

@@ -23,9 +23,9 @@ function print_update_error() {
 }
 
 function find_executable() {
-  local readonly executable="$1"
-  local readonly version="$2"
-  local readonly path=$(which "${executable}")
+  local -r executable="$1"
+  local -r version="$2"
+  local -r path=$(which "${executable}")
   if [ ! -x "${path}" ]; then
     echo -e "${RED}[Error] Could not find ${executable}${NC}"
     print_update_error

starter_project/autonomy/lint.sh

@@ -12,9 +12,9 @@ function print_update_error() {
 }
 
 function find_executable() {
-  local readonly executable="$1"
-  local readonly version="$2"
-  local readonly path=$(which "${executable}")
+  local -r executable="$1"
+  local -r version="$2"
+  local -r path=$(which "${executable}")
   if [ ! -x "${path}" ]; then
     echo -e "${RED}[Error] Could not find ${executable}${NC}"
     print_update_error

starter_project/teleop/gui_starter_frontend.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 
-cd basestation_gui/frontend
+cd basestation_gui/frontend || exit 1
 bun run watch

style.sh

@@ -3,8 +3,8 @@
 # See: https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/
 set -Eeuo pipefail
 
-# Prevent globbing from failing if no files match
-shopt -s nullglob
+shopt -s nullglob globstar
+GLOBIGNORE="./venv/**"
 
 readonly RED='\033[0;31m'
 readonly NC='\033[0m'
@@ -86,11 +86,12 @@ echo "Linting Python with mypy ..."
 if command -v shellcheck &> /dev/null; then
   echo
   echo "Linting bash scripts with shellcheck ..."
-  readonly SHELL_FILES=$(find . -depth 1 -name "*.sh")
-  for file in $SHELL_FILES; do
-    # SC2155 is separate declaration and command.
-    shellcheck "${file}" --exclude=SC2155
-  done
+  readonly SHELL_FILES=(
+    ./**/*.sh
+  )
+  # SC2155 is separate declaration and command.
+  shellcheck --exclude=SC2155 "${SHELL_FILES[@]}"
+  echo "Done"
 fi
 
 if [ $# -eq 0 ] || [ "$1" != "--fix" ]; then