Added default forum user permissions #414
Conversation
There was a problem hiding this comment.
Review
The permissions are reasonable, and the documentation is a great inclusion. LGTM.
Proof of functionality
forum_viewable_authorized.mov
[email protected] is unauthenticated
|
|
||
| # This setting define which permissions should be granted to all authenticated | ||
| # users. Note that the permissions specified in this list are granted only if a | ||
| # given forum does not have any permissions set for a given authenticated user. | ||
| # | ||
| # In the future, it may become desirable to take a more fine-grain approach to | ||
| # user permissions on the chigame forum, more information on how to implement | ||
| # such an approach and a full list of permissions can be found at this link. | ||
| # https://django-machina.readthedocs.io/en/latest/forum_permissions.html | ||
| # | ||
| # https://django-machina.readthedocs.io/en/latest/settings.html#machina-default-authenticated-user-forum-permissions | ||
| MACHINA_DEFAULT_AUTHENTICATED_USER_FORUM_PERMISSIONS = [ | ||
| "can_see_forum", | ||
| "can_read_forum", | ||
| "can_start_new_topics", | ||
| "can_reply_to_topics", | ||
| "can_edit_own_posts", | ||
| "can_post_without_approval", | ||
| "can_create_polls", | ||
| "can_vote_in_polls", | ||
| "can_download_file", | ||
| ] |
There was a problem hiding this comment.
These permissions look correct, and thank you for the documentation
There was a problem hiding this comment.
I can successfully sign in as a non-admin user and see the posts!
Then when I'm completely signed out, I cannot see any posts in the forum!
A good next issue to come from this would be a landing page of some sorts that recognizes if the user is not signed in and tells them they need to sign in to view the forum + a link to sign in.
This way someone who's not signed in will know that "yes, things actually have been posted to the forum, I just can't see them". Instead of "this forum looks empty, I have no idea if this is because there are no posts or if I can't see them.
Thank you for your documention!! Particularly for future implementation. This is phenomenal to put in code as well as github issues.
Thank you for your work!
|
Closed without significant revision. Thanks to @bburgess19 for reviewing the PR and for the video documenting the result. @majorsylvie We already had an issue open to create a landing page, although it was recently closed due to inactivity and lack of a clear purpose. However, I've gone ahead and reopened it and clarified that it should cater to unauthenticated users, referencing your comment here. |
|
Issue Score: Excellent |
To address issue #412, I've added the necessary django-machina setting to define default user permissions on the forum.