Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default forum permissions setting #412

Closed
joshuamonroe opened this issue Dec 5, 2023 · 3 comments · Fixed by #414
Closed

Add default forum permissions setting #412

joshuamonroe opened this issue Dec 5, 2023 · 3 comments · Fixed by #414
Assignees
Labels
Milestone

Comments

@joshuamonroe
Copy link
Contributor

joshuamonroe commented Dec 5, 2023

During testing I noticed that regular user accounts do not have permissions to view the forums.

This is the forum viewed as an admin. Thus far, most testing has been done from an admin account.
Image

And this is the same forum viewed as a regular user.
Image

A fix would be pretty easy, we would just need to set django-machina's default authenticated user permissions setting according to the defaults provided here. This would apply to all authenticated users across all forums that don't have more restrictive permissions.

MACHINA_DEFAULT_AUTHENTICATED_USER_FORUM_PERMISSIONS = [
    'can_see_forum',
    'can_read_forum',
    'can_start_new_topics',
    'can_reply_to_topics',
    'can_edit_own_posts',
    'can_post_without_approval',
    'can_create_polls',
    'can_vote_in_polls',
    'can_download_file',
]

Alternatively, we could consider setting permissions manually on a per forum basis, more info on what that would entail and a full list of possible permissions can also be found here.

@joshuamonroe joshuamonroe converted this from a draft issue Dec 5, 2023
@joshuamonroe joshuamonroe self-assigned this Dec 5, 2023
@joshuamonroe joshuamonroe moved this from Sprint Backlog to In Progress in CMSC 22000 Scrum Board Dec 5, 2023
@joshuamonroe joshuamonroe linked a pull request Dec 5, 2023 that will close this issue
@joshuamonroe
Copy link
Contributor Author

I've added the the necessary permissions setting and submitted a pull request to merge it into dev

@github-project-automation github-project-automation bot moved this from In Progress to Done in CMSC 22000 Scrum Board Dec 5, 2023
@joshuamonroe
Copy link
Contributor Author

Closed after successfully merging and closing #414. Thanks to @bburgess19 for reviewing the PR.

@majorsylvie
Copy link
Contributor

Issue Score: Excellent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants