Displaying Historical Information on a user view #365
Conversation
|
Update: I implemented the code such that there is statistics for matches played, matches won, tournaments played, tournaments won. I added the attributes in views.py in the users folder. I also went into userprofile_detail.html and added a link to the user's stats. The button works and goes to the user's stats. This can be accessed by any user if they go on the user's profile. |
| @@ -34,6 +34,8 @@ | |||
| <a href="{% url 'users:add-friend' object.user.pk %}" | |||
| class="btn btn-primary">Add Friend</a> | |||
| {% endif %} | |||
| <a href="{% url 'users:user-history' object.user.pk %}" | |||
| class="btn btn-primary">Stats</a> | |||
There was a problem hiding this comment.
Once you merge dev, you will see that the Edit Profile and Account buttons are sectioned off separately from the general profile buttons such as the Friend Request buttons and the Stats button. The Friend Request and stats buttons should be wrapped such that they either appear alongside the other buttons or such that there is space between the two rows of buttons.
There was a problem hiding this comment.
Got it, I'll add them into the if statements just like I did with the account button so it looks cleaner
There was a problem hiding this comment.
Changes to views and user_history align. The logic for displaying user stats in the user_history page works well, but the button placement is a little odd in userprofile_detail.html. I have added specific comments there to address the button and where it should be placed; other than that this PR LGTM!
src/chigame/users/views.py
Outdated
| match_count = Match.objects.filter(players__in=[user]).count() | ||
| match_wins = Player.objects.filter(Q(user=user, outcome=Player.WIN) | Q(team=user, outcome=Player.WIN)).count() | ||
|
|
||
| tournament_count = Tournament.objects.filter(players__in=[user]).count() |
There was a problem hiding this comment.
Hm this isn't quite right because it's just counting if the player is currently in a tournament (could be on going). If you could add another filter where the tournament_end_date < timezone.now() that should make this work.
There was a problem hiding this comment.
That's a good filter I wasn't aware of, I'll use that
src/chigame/users/views.py
Outdated
| @@ -72,7 +74,23 @@ def user_history(request, pk): | |||
| try: | |||
| user = User.objects.get(pk=pk) | |||
|
|
|||
| return render(request, "users/user_history.html", {"user": user}) | |||
| match_count = Match.objects.filter(players__in=[user]).count() | |||
There was a problem hiding this comment.
Same comment as for tournaments. I think you might want to use Lobby here instead of match and filter for match_status = 3.
There was a problem hiding this comment.
I'll implement it since it has a match_status I can take advantage of
|
I implemented the requested changes, but my only comment is that a user can be in a match if assigned by an admin, and not be in a lobby. I think there should be some functionality in the future to require a lobby for a match just so a person can't have matches won, but no matches played due to it being tied to lobbies. |
|
Added back remove friend functionality; got removed elsewhere in another PR. |
24raniwalar
force-pushed
the
users/hist-info
branch
from
6371135 to
2e076ea
Compare
|
Closing comment: In this PR, we created a view that can be accessed in the profile of a user that displays the stats of a user, so for example, how many matches a user has been in, how many matches they've won, how many tournaments they've participated in and how many have they won. This is visible to any user when looking at another user's profile. One thing is that match count is linked to lobby, and since an admin can manually add a user to a match without a lobby, there should be something in the future that mandates a lobby for a match such that the numbers stay consistent. Also in the future, there should be more stats, such as rank in Chigame website, and maybe win rate, and things like that. |
|
Issue Score: Excellent Comments: |
This pull request addresses issue #300 where it aims to display the correct historical information such as games won and such to a view where any view can access it.