Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement historical information from view #300

Closed
AndrewM131 opened this issue Nov 27, 2023 · 5 comments · Fixed by #365
Closed

Implement historical information from view #300

AndrewM131 opened this issue Nov 27, 2023 · 5 comments · Fixed by #365

Comments

@AndrewM131
Copy link
Contributor

AndrewM131 commented Nov 27, 2023

This will allow for the historical information of a user to be displayed on a page. For example, how many games a user has won, and achievements of that degree.

@AndrewM131 AndrewM131 self-assigned this Nov 27, 2023
@AndrewM131 AndrewM131 converted this from a draft issue Nov 27, 2023
@AndrewM131 AndrewM131 added this to the 2023/Sprint 3 milestone Nov 27, 2023
@AndrewM131 AndrewM131 moved this from Sprint Backlog to In Progress in CMSC 22000 Scrum Board Nov 27, 2023
@AndrewM131 AndrewM131 linked a pull request Dec 1, 2023 that will close this issue
@AndrewM131
Copy link
Contributor Author

Update: PR has been made, but now review yet

@AndrewM131
Copy link
Contributor Author

Update: I implemented the code such that there is statistics for matches played, matches won, tournaments played, tournaments won. I added the attributes in views.py in the users folder. I also went into userprofile_detail.html and added a link to the user's stats. The button works and goes to the user's stats. This can be accessed by any user if they go on the user's profile.

@AndrewM131
Copy link
Contributor Author

Closing comment: In this issue, we successfully created a view that can be accessed in the profile of a user that displays the stats of a user, so for example, how many matches a user has been in, how many matches they've won, how many tournaments they've participated in and how many have they won. This is visible to any user when looking at another user's profile. In the future, there should be something that mandates a lobby for a match. Also in the future, there should be more stats, such as rank in Chigame website, and maybe win rate, and things like that.
We met twice to discuss progress and updates on the issue, and during these meetings, I coded on my laptop with comments from Henrietta and Ishi. We also communicated over slack if we made progress on the issue, and Rishabh reviewed and help fix issues with the merge.

@AndrewM131
Copy link
Contributor Author

Closing comment: In this issue, we successfully created a view that can be accessed in the profile of a user that displays the stats of a user, so for example, how many matches a user has been in, how many matches they've won, how many tournaments they've participated in and how many have they won. This is visible to any user when looking at another user's profile. One thing is that match count is linked to lobby, and since an admin can manually add a user to a match without a lobby, there should be something in the future that mandates a lobby for a match such that the numbers stay consistent. Also in the future, there should be more stats, such as rank in Chigame website, and maybe win rate, and things like that.
We met over the course of the sprint 2 or 3 times to code, mainly on my laptop, and Henrietta and Ishi would review and offer suggestions on the code. We also communicated over slack of any progress we made. Rishabh reviewed and fixed the finishing issues with the PR.

@elizabethli31
Copy link
Contributor

Issue Score: Excellent

Comments:
Summary description is a little too brief but good work on the actual implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants