-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for getting game lists using serializers and the api-game… #336
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
037b3fe
Added tests for getting game lists using serializers and the api-game…
giomhern f3460a4
Merge branch 'dev' into apis/get-game-tests
giomhern 205fc96
Merge branch 'dev' into apis/get-game-tests
giomhern af764cf
Fixing run tests failures due to dictionary access
giomhern 4748579
Merge branch 'dev' into apis/get-game-tests
giomhern 9d0183f
Merge branch 'dev' into apis/get-game-tests
giomhern 3f297ca
Merge branch 'dev' into apis/get-game-tests
giomhern 20e2fc7
Merge branch 'dev' into apis/get-game-tests
giomhern 8e62ae4
Merge branch 'dev' into apis/get-game-tests
majorsylvie bff5bfb
Added comment for why key indexing is necessary for different types
giomhern 4498e1a
Merge remote-tracking branch 'origin/apis/get-game-tests' into apis/g…
giomhern 0d3b05b
Comment for helper function part 2
giomhern File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should include a why in the code comment.
Why use/need key indexing for what attriutes.