Added tests for getting game lists using serializers and the api-game… #336
Conversation
src/chigame/api/tests/test_api.py
Outdated
| @@ -17,7 +21,14 @@ def check_equal(self, obj, expected: dict): | |||
| Helper function to check that the object data matches the expected data. | |||
| """ | |||
| for key in expected: | |||
| self.assertEqual(getattr(obj, key), expected[key]) | |||
| if isinstance(obj, (ReturnDict, dict)): | |||
| # Use key indexing for dictionaries and ReturnDict | |||
There was a problem hiding this comment.
This should include a why in the code comment.
Why use/need key indexing for what attriutes.
|
|
||
| # For example, without this check, you might encounter issues | ||
| # when comparing Decimal('5') and '5.00', | ||
| # which would fail due to type mismatch despite representing the same value. |
There was a problem hiding this comment.
Absolutely fantastic code comment.
Clear, direct, justified, with an example to boot!
Thank you for your work
|
This PR, rooted in Issue #327, was focused on enhancing and ensuring that our GET API endpoint for games and the associated factory worked up to standards. Previously, we had an issue of mismatched values within the serialized and unserialized data which would cause the tests to fail. This has now been resolved in the helper function Thank you to @giomhern for coding up the tests and @cuyakonwu for the help reviewing! |
|
Issue Score: Excellent Comments: |
This is the pull request associated with issue #327 on creating more advanced and adequate checks are made on the Game List and that the Games produced with the factories are the same as those from the response.