-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player Accessibility #16
Merged
clpetersonucf
merged 16 commits into
ucfopen:dev/1.3.0
from
FrenjaminBanklin:issue/9-player-accessibility
Jul 24, 2019
Merged
Player Accessibility #16
clpetersonucf
merged 16 commits into
ucfopen:dev/1.3.0
from
FrenjaminBanklin:issue/9-player-accessibility
Jul 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s moving along.
…rent cell is being read out properly every time now.
…ions for screen readers. Last thing might be getting tab order worked out and enriching the submit button to list out progress etc., also locking letters when taking a free word.
… it seems like repetitive readings have been squashed.
…rently provided for a word or indicate which (if any) letters are missing for a word.
…trying to figure stuff out.
…e there's no way of preventing default keybinds from firing.
…current clue. Replaced all ':' characters with '.' to make the readout (hopefully) more friendly with JAWS.
… display an alert with only an 'Okay' button. Added alert box for keyboard instructions. Made it easier to confirm/cancel alerts with the keyboard.
…o prevent future changes, are also styled differently to indicate such.
…ry much to be desired.
clpetersonucf
requested changes
Jul 24, 2019
…utton's screen reader helper. Made it possible to press the 'R' key to re-read the contents of the alert window.
clpetersonucf
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9.
Lots of changes to the player to make it accessible to keyboard-only/vision-impaired users.
Added bonus, new feature: letter tiles can now be locked, preventing them from being accidentally edited after a free word is chosen.