Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Accessibility #16

Merged

Conversation

FrenjaminBanklin
Copy link
Contributor

Closes #9.

Lots of changes to the player to make it accessible to keyboard-only/vision-impaired users.

Added bonus, new feature: letter tiles can now be locked, preventing them from being accidentally edited after a free word is chosen.

…rent cell is being read out properly every time now.
…ions for screen readers. Last thing might be getting tab order worked out and enriching the submit button to list out progress etc., also locking letters when taking a free word.
… it seems like repetitive readings have been squashed.
…rently provided for a word or indicate which (if any) letters are missing for a word.
…e there's no way of preventing default keybinds from firing.
…current clue. Replaced all ':' characters with '.' to make the readout (hopefully) more friendly with JAWS.
… display an alert with only an 'Okay' button. Added alert box for keyboard instructions. Made it easier to confirm/cancel alerts with the keyboard.
…o prevent future changes, are also styled differently to indicate such.
src/player.html Outdated Show resolved Hide resolved
…utton's screen reader helper. Made it possible to press the 'R' key to re-read the contents of the alert window.
Copy link
Member

@clpetersonucf clpetersonucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@clpetersonucf clpetersonucf merged commit 8d665ad into ucfopen:dev/1.3.0 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants