Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pam/gdmmodel): Forward public AuthModeSelected to GDM #631

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix(pam/gdmmodel): Forward public AuthModeSelected to GDM #631

merged 4 commits into from
Nov 13, 2024

Commits on Nov 13, 2024

  1. pam/model: Add utility function to update client-specific models 

    Avoid repeating the same logic multiple times when we've to update
client-specific models
    @3v1n0
    3v1n0 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8b7cd99 View commit details
    Browse the repository at this point in the history

  2. pam/gdmmodel: Forward public AuthModeSelected to GDM 

    authModeSelected event we were listening to is an event that may be
ignored or adjusted depending on authModeSelection model logic, so it's
what we should also expose to GDM.

We couldn't do that though since the event wasn't forwarded, so do it.

It should help with flacky tests such as [1].

[1] https://github.com/ubuntu/authd/actions/runs/11802896113/job/32879602555?pr=583
    @3v1n0
    3v1n0 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    eecd9d6 View commit details
    Browse the repository at this point in the history

  3. gdmmodel: Use utility function we already have for user selection

    @3v1n0
    3v1n0 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2cd9c71 View commit details
    Browse the repository at this point in the history

  4. pam/gdmmodel-test: Never inject userSelected events in tests simulati… 

    …ng daemon

We don't really support user-selection from the daemon, so it's not
worth to test it, while the user can be pre-set using PAM instead so
stress testing on this case instead.

As per this drop some duplicated tests we had (they were covered already
by "Broker selection stage caused by PAM user selection")
    @3v1n0
    3v1n0 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    75bdc48 View commit details
    Browse the repository at this point in the history