fix(pam/gdmmodel): Forward public AuthModeSelected to GDM #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid repeating the same logic multiple times when we've to update client-specific models
authModeSelected event we were listening to is an event that may be ignored or adjusted depending on authModeSelection model logic, so it's what we should also expose to GDM. We couldn't do that though since the event wasn't forwarded, so do it. It should help with flacky tests such as [1]. [1] https://github.com/ubuntu/authd/actions/runs/11802896113/job/32879602555?pr=583
adombeck
approved these changes
Nov 13, 2024
…ng daemon We don't really support user-selection from the daemon, so it's not worth to test it, while the user can be pre-set using PAM instead so stress testing on this case instead. As per this drop some duplicated tests we had (they were covered already by "Broker selection stage caused by PAM user selection")
3v1n0
force-pushed
the
gdm-auth-mode-selection-checked
branch
from
c7821d7
to
75bdc48
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 82.92% 82.98% +0.06%
==========================================
Files 80 80
Lines 8589 8587 -2
Branches 75 75
==========================================
+ Hits 7122 7126 +4
+ Misses 1132 1130 -2
+ Partials 335 331 -4 ☔ View full report in Codecov by Sentry. |
adombeck
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authModeSelected event we were listening to is an event that may be
ignored or adjusted depending on authModeSelection model logic, so it's
what we should also expose to GDM.
We couldn't do that though since the event wasn't forwarded, so do it.
Also simplify user selection on GDM tests, by mimicking more what we really do.
It should help with flacky tests such as [1].
[1] https://github.com/ubuntu/authd/actions/runs/11802896113/job/32879602555?pr=583
UDENG-5261