-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge po #631
Merge po #631
Conversation
@peat-psuwit @Danfro ready for review to demonstrate that the structure should be ok:
|
btw. I'd prefer the commits not be squashed. they are not all 100% clean, but still explain the pot surgery better than if they were squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they look good. But if you prefer the commits not to be squashed, then please also cleanup git commit messages. For example, "unbreakeroo" is not a good commit message. git rebase -i
is a good tool to do that.
Actually, preferably the commits themselves should also be cleaned up. But I guess that could be more complicated.
okok. I'll clean it up |
by running ./update-translations.sh
not sure what this was supposed to do, but right now it does nothing and seems unnecessary
remove bits that msgcat is complaining about in preparation to run merge_po.sh
instead of one per language AND section just one per language done by using merge_po.sh
instead of one per section
by rerunning update-translations.sh again to make sphinx generate the single pot then add this and remove the old ones
using update-po.sh
ok. now it comes as a clean commit history that accurately documents the steps performed for this pot surgery. @peat-psuwit please re-review |
No description provided.