Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge translations into a single file per language #630

Closed
doniks opened this issue Dec 16, 2024 · 3 comments · Fixed by #631
Closed

merge translations into a single file per language #630

doniks opened this issue Dec 16, 2024 · 3 comments · Fixed by #631

Comments

@doniks
Copy link
Collaborator

doniks commented Dec 16, 2024

for context see: #628

@doniks doniks linked a pull request Dec 16, 2024 that will close this issue
@doniks
Copy link
Collaborator Author

doniks commented Dec 16, 2024

added a PR to try to do this: #631

as far as I can see, jenkins CI only builds the english version, so that's no good to test whether the translation setup works ok

I thiiink, I can ask rtd to build this branch. I've added en and de for now to to test:

So, that doesn't work yet, DE version is all EN. which doesn't really surprise me since I probably need to figure out how sphinx will pick up the translations from the new merged file ....

@doniks
Copy link
Collaborator Author

doniks commented Dec 16, 2024

ooookay ... I guess I'm kinda there ...

@doniks
Copy link
Collaborator Author

doniks commented Dec 16, 2024

alright. seems to look ok. @Danfro helped me with a weblate smoke test (with locked weblate component), where a reasonable number of languages and translated strings showed up

@doniks doniks mentioned this issue Dec 17, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant