Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix core contracts storage check #973

Closed
wants to merge 79 commits into from

feat: rollback check_storage_layou to @v3

f768506
Select commit
Loading
Failed to load commit list.
Closed

feat: fix core contracts storage check #973

feat: rollback check_storage_layou to @v3
f768506
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Semgrep OSS failed Oct 3, 2024 in 6s

3 new alerts including 1 error

New alerts in code changed by this pull request

  • 1 error
  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check failure on line 171 in packages/contracts/src/dollar/amo/AaveAmo.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.arbitrary-low-level-call Error

An attacker may perform call() to an arbitrary address with controlled calldata

Check notice on line 148 in packages/contracts/src/dollar/core/UbiquityAmoMinter.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow

Check notice on line 149 in packages/contracts/src/dollar/core/UbiquityAmoMinter.sol

See this annotation in the file changed.

Code scanning / Semgrep OSS

Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note

Possible arithmetic underflow