feat: fix core contracts storage check #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition and price feed setup
…ng limits with fuzzing
…r price manipulation tests
…on and update invariant
…d mintUbiquityDollars
zugdev
force-pushed
the
fix-core-contracts-storage-check
branch
from
b2c1983 to
f768506
Compare
|
this looks very ugly because of rebase, i'll do better |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uint256 _value, | ||
| bytes calldata _data | ||
| ) external onlyOwner returns (bool, bytes memory) { | ||
| (bool success, bytes memory result) = _to.call{value: _value}(_data); |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.security.arbitrary-low-level-call Error
| int256 collateralAmount_i256 = int256(collateralAmount); | ||
|
|
||
| // Update the collateral balances | ||
| collateralBorrowedBalances[msg.sender] -= collateralAmount_i256; |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note
|
|
||
| // Update the collateral balances | ||
| collateralBorrowedBalances[msg.sender] -= collateralAmount_i256; | ||
| collateralTotalBorrowedBalance -= collateralAmount_i256; |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: rules.solidity.security.basic-arithmetic-underflow Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #972