Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Add sync workflow for config param names #357

Closed
rndquu opened this issue Jun 1, 2023 · 19 comments · Fixed by #617
Closed

Add sync workflow for config param names #357

rndquu opened this issue Jun 1, 2023 · 19 comments · Fixed by #617

Comments

@rndquu
Copy link
Member

rndquu commented Jun 1, 2023

Depends on #327

We are in the process of an active development so we refactor the bot's config param names occasionally.

The latest refactors (both implemented and planned):

  • move from camel case to kebab case (implemented)
  • refactor chainId to networkId (planned)

Updating config param names for all our partners is tedious. We should automate this process.

What should be done:

So in the end the workflow should be able to create config update PRs which:

  1. Add newly added bot's config params
  2. Rename config params (example: chain-id => evm-network-id)
@ghost
Copy link

ghost commented Jul 18, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Jul 18, 2023

Deadline Wed, 19 Jul 2023 21:55:41 GMT
Registered Wallet 0x2bBc6a8314044d70684C74CfA0E117eb75E3708c
Payment Multiplier 1.00
Multiplier Reason
Total Bounty 300 USD
Tips:
  • Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @ubiquibot ubiquibot bot assigned ghost Jul 18, 2023
    @rndquu rndquu mentioned this issue Jul 26, 2023
    @ubiquibot ubiquibot bot unassigned ghost Jul 28, 2023
    @EtherealGlow
    Copy link
    Contributor

    EtherealGlow commented Jul 28, 2023

    /start

    @ubiquibot
    Copy link

    ubiquibot bot commented Jul 28, 2023

    Deadline Sat, 29 Jul 2023 17:19:11 GMT
    Registered Wallet 0x3b07d616EC780b22148b190A07F3829A11B11042
    Payment Multiplier 1.00
    Multiplier Reason
    Total Bounty 300 USD
    Tips:
    • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
    • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
    • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

      @0x4007
      Copy link
      Member

      0x4007 commented Jul 30, 2023

      Another idea for a simple solution (probably too late to pitch this though) the bot should reply to closed as completed issues in the payout comment with an error message saying that the config didn't parse correctly and that it's using the organization defaults.

      I feel like this is the most confusing time for contributors.

      @rndquu
      Copy link
      Member Author

      rndquu commented Jul 30, 2023

      Another idea for a simple solution (probably too late to pitch this though) the bot should reply to closed as completed issues in the payout comment with an error message saying that the config didn't parse correctly and that it's using the organization defaults.

      I feel like this is the most confusing time for contributors.

      Perhaps when #383 is finally merged we could create a task like "The bot should comment with an error message if it finds an unrecognized config param name (i.e. unrecognized config param name doesn't exist in the default config)"

      @0x4007
      Copy link
      Member

      0x4007 commented Jul 30, 2023

      Do you think you could take over my attempt at fixing the default config in my pr if you have time this upcoming couple of days?

      https://github.com/Venoox/ubiquibot/pull/18

      The part I got hung up on was the default configs. I have more comments on it in my pr here.

      I think I resolved the merge conflicts well but I'm quite confused around the defaults and am not confident on how to proceed.

      @rndquu
      Copy link
      Member Author

      rndquu commented Jul 30, 2023

      Do you think you could take over my attempt at fixing the default config in my pr if you have time this upcoming couple of days?

      Venoox#18

      The part I got hung up on was the default configs. I have more comments on it in my pr here.

      I think I resolved the merge conflicts well but I'm quite confused around the defaults and am not confident on how to proceed.

      I'll check it

      @0x4007
      Copy link
      Member

      0x4007 commented Jul 30, 2023

      It might be wise to diff my pull request against upstream (@ubiquity/ubiquibot) development head to filter for only my relevant changes.

      @ghost
      Copy link

      ghost commented Jul 30, 2023

      @rndquu seems like the person assigned to this issue kinda confused also it passed the deadline i was before working on this but due to some thing couldn't come online if they continue to be confused can i be assigned again if u guys don't mind

      @EtherealGlow
      Copy link
      Contributor

      only like making the pr is left, it did update the file in the logs

      @EtherealGlow
      Copy link
      Contributor

      /wallet 0xa611a37657A76583305F557D63B94834a35C7bF4

      @ubiquibot
      Copy link

      ubiquibot bot commented Aug 1, 2023

      Skipping to register the wallet address because you have not provided a valid SIGNATURE_HASH.
      Use etherscan to sign the message DevPool and register your wallet by appending the signature hash.

      Usage:
      /wallet <WALLET_ADDRESS | ENS_NAME> <SIGNATURE_HASH>

      Example:
      /wallet 0x16ce4d863eD687455137576da2A0cbaf4f1E8f76 0x0830f316c982a7fd4ff050c8fdc1212a8fd92f6bb42b2337b839f2b4e156f05a359ef8f4acd0b57cdedec7874a865ee07076ab2c81dc9f9de28ced55228587f81c

      @EtherealGlow
      Copy link
      Contributor

      /wallet 0xa611a37657A76583305F557D63B94834a35C7bF4
      0x411cb85ee378f7411e93b3cfb0dbe4f50740de241052793abb2f6796b1862af21a04468b8d734f3a93e84480bed5aae3e09c71cec374bf2f3906ca6ceb16a7971c

      @ubiquibot
      Copy link

      ubiquibot bot commented Aug 1, 2023

      Updated the wallet address for @EtherealGlow successfully! Your new address: 0xa611a37657A76583305F557D63B94834a35C7bF4

      @ubiquibot
      Copy link

      ubiquibot bot commented Aug 9, 2023

      Do you have any updates @EtherealGlow? If you would like to release the bounty back to the DevPool, please comment /unassign
      Last activity time: Sat Aug 05 2023 11:39:02 GMT+0000 (Coordinated Universal Time)

      @0x4007 0x4007 added ping and removed ping labels Aug 9, 2023
      @ubiquibot
      Copy link

      ubiquibot bot commented Aug 14, 2023

      @EtherealGlow - Releasing the bounty back to dev pool because the allocated duration already ended!
      Last activity time: Tue Aug 01 2023 13:08:54 GMT+0000 (Coordinated Universal Time)

      @EtherealGlow
      Copy link
      Contributor

      man why you gotta do me like that

      @ubiquibot
      Copy link

      ubiquibot bot commented Aug 18, 2023

      [ CLAIM 300 WXDAI ]

      0xa611a376...4a35C7bF4

      If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

      Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
      Projects
      None yet
      3 participants