Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Refactor chain to network #358

Closed
rndquu opened this issue Jun 1, 2023 · 5 comments · Fixed by #509
Closed

Refactor chain to network #358

rndquu opened this issue Jun 1, 2023 · 5 comments · Fixed by #509
Assignees
@BeanieMen
Labels
Priority: 1 (Normal) Time: <1 Hour

Comments

@rndquu
Copy link
Member

rndquu commented Jun 1, 2023

Depends on #357

Original comment

What should be refactored:

  • variables and constants (chainId => networkId, etc...)
  • function names (getChainId => getNetworkId, etc...)
  • bot config param (chain-id => network-id)

P.S. This is a low priority issue
@ubiquibot ubiquibot bot mentioned this issue Jun 1, 2023
Closed
@starlitnightsky
Copy link
Contributor

I have a question. Should I wait for until #357 is finished?

@rndquu
Copy link
Member Author

rndquu commented Jun 9, 2023

I have a question. Should I wait for until #357 is finished?

yes

@harjaapdhillon16 harjaapdhillon16 mentioned this issue Jun 11, 2023
Open
@BeanieMen
Copy link
Contributor

BeanieMen commented Jul 14, 2023 •
edited by 0x4007
Loading

/start

@ubiquibot
Copy link

ubiquibot bot commented Jul 14, 2023

Deadline Fri, 14 Jul 2023 20:08:43 GMT
Registered Wallet 0x18E90bBCbDFde054990C549B34b52Fb77f70A0c5
Payment Multiplier 1.00
Multiplier Reason
Total Bounty 18.75 USD
Tips:
  • Use /wallet 0x4FDE...BA18 if you want to update your registered payment wallet address @user.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

    @ubiquibot ubiquibot bot added the Permitted label Jul 17, 2023
    @ubiquibot
    Copy link

    ubiquibot bot commented Jul 17, 2023

    [ CLAIM 18.75 WXDAI ]

    0x18E90bBCb...b77f70A0c5

    If you enjoy the DevPool experience, please follow Ubiquity on GitHub and star this repo to show your support. It helps a lot!

    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Assignees

    @BeanieMen BeanieMen

    Labels
    Priority: 1 (Normal) Time: <1 Hour
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging a pull request may close this issue.

    chore: replace all 'chain' with 'network' BeanieMen/ubiquibot
    4 participants
    @0x4007 @BeanieMen @rndquu @starlitnightsky