Refactor config

[BeanieMen]

Resolves #497

This pr is made to refactor the ubiquibot-config.yml file

[netlify]

✅ Deploy Preview for ubiquibot-staging ready!

Name	Link
🔨 Latest commit	fffb9af
🔍 Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/64c26ad52447df0008300ce6
😎 Deploy Preview	https://deploy-preview-512--ubiquibot-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[BeanieMen]

@0xcodercrane can you also review this

[BeanieMen]

@0xcodercrane have you got any updates for any of my prs?

[BeanieMen]

@pavlovcik can you resolve this conflicts
Thank you

[0xcodercrane]

@pavlovcik can you resolve this conflicts Thank you

Do you have any blockers to resolve conflicts? Bounty admins can definitely suggest code changes that might generate a couple of conflicts but if its not an impossible one and doesn't require lots of work, hunters should be responsible for resolving conflicts.

[BeanieMen]

@0xcodercrane sorry about that.
ill try to be less dependent

[BeanieMen]

any updates on this?

[0xcodercrane]

The codebase looks good. The PR requires changes in configuration file so I am tagging @rndquu for a review and collaboration in configuration changes in ubiquity/ubiquibot, ubiquibot/staging, ubiquibot/production repos. I guess everything should happen at a same time.

[BeanieMen]

thanks

[rndquu]

@me505 The original issue describes renaming analytics-mode to disable-analytics. Is it implemented?

[BeanieMen]

sorry about that!
i thought because of this that i shouldnt implement it

[rndquu]

The codebase looks good. The PR requires changes in configuration file so I am tagging @rndquu for a review and collaboration in configuration changes in ubiquity/ubiquibot, ubiquibot/staging, ubiquibot/production repos. I guess everything should happen at a same time.

There is a separate issue exactly for this "renaming" case

Initially the current issue should've been dependent on this one. This way we could perform a smooth update.

Anyway, when the current PR is merged and a new bot's production version is released the following PRs should be merged:

• https://github.com/ubiquity/ubiquibot-config/pull/3
• https://github.com/ubiquibot/ubiquibot-config/pull/2

[rndquu]

If disable-analytics is true then here !analyticsMode is false thus actually enabling analytics instead of disabling it

[rndquu]

If partner has disable-analytics: true then here !analyticsMode is false thus enabling analytics instead of disabling it

I guess we need to refactor analyticsMode to disableAnalytics in the bot's code

[BeanieMen]

ill assume you want analytics on

[0x4007]

My only hesitation is if the logic is implemented correctly:

• If disable-analytics property is not on the config, then analytics should be enabled.
• If disable-analytics: true then analytics should be disabled
• If disable-analytics: false then analytics should be enabled.

@rndquu @0xcodercrane what do you guys think of the code?

[rndquu]

My only hesitation is if the logic is implemented correctly:

• If disable-analytics property is not on the config, then analytics should be enabled.
• If disable-analytics: true then analytics should be disabled
• If disable-analytics: false then analytics should be enabled.

@rndquu @0xcodercrane what do you guys think of the code?

PR looks good, the logic is implemented correctly