Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: restore logo css #340

Merged
merged 1 commit into from
Oct 18, 2024
Merged

style: restore logo css #340

merged 1 commit into from
Oct 18, 2024

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Oct 16, 2024

Resolves #339

I've double checked all of the css styles changes between "pre gift card mint" and "post gift card mint" branches:

  • logo css styles are restored
  • all other css styles are inplace (almost untouched)

@ubiquity-os-deployer
Copy link

Copy link
Contributor

Preview Deployment
56636efd446e667e06d8c0eaaf2cba73fc0f24b9

@rndquu rndquu marked this pull request as ready for review October 16, 2024 12:43
@rndquu rndquu requested a review from Keyrxng as a code owner October 16, 2024 12:43
@rndquu rndquu requested review from 0x4007 and removed request for Keyrxng October 16, 2024 12:43
@0x4007
Copy link
Member

0x4007 commented Oct 16, 2024

The brightness of the logo doesn't match the text, so this can't be 100% accurate.
4716d2d6 pay-ubq-fi pages dev__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiMTA2OTE1Mjg2MTI4NTQyNzkyMDEzNTEzMjUzODA

@rndquu
Copy link
Member Author

rndquu commented Oct 17, 2024

The brightness of the logo doesn't match the text, so this can't be 100% accurate

They do match. I've compared current pay.css when the one dated back by 29th May at this commit and there're no any changes in the logo styles. Besides both the logo image and text have the same 0.5 opacity so they can't be different in brightness:
Screenshot 2024-10-17 at 15 30 07

@0x4007
Copy link
Member

0x4007 commented Oct 17, 2024

Just make sure "fill: currentColor"

@0x4007 0x4007 merged commit 0ad1138 into ubiquity:development Oct 18, 2024
3 checks passed
@rndquu rndquu deleted the feat/339 branch October 18, 2024 07:37
@rndquu
Copy link
Member Author

rndquu commented Oct 18, 2024

Just make sure "fill: currentColor"

Both svg logo and logo text have the same fill color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore Clobbered Header Styles
2 participants