Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Clobbered Header Styles #339

Closed
0x4007 opened this issue Oct 15, 2024 · 7 comments · Fixed by #340
Closed

Restore Clobbered Header Styles #339

0x4007 opened this issue Oct 15, 2024 · 7 comments · Fixed by #340

Comments

@0x4007
Copy link
Member

0x4007 commented Oct 15, 2024

Needs to be restored as my fixes were clobbered in pay.css at 84c49d8#diff-ac07c029a5c9ea7b89c95149341910381772e0a5d90f6470ca24d96ec55f2748

Current incorrect header:

pay ubq fi__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiI4NDkwMDAwMDAwMDAwMDAwMDAwIn0sIm5vbmNlIjoiNzY5NjUzNjc0NDQwNTQ3MzkwNTYzOTgwMT

Correct header:

694833ca pay-ubq-fi pages dev__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNTA3MjU2MTcyNzI2MzU2MTU0OTk1NjU0NDE0ODE

https://694833ca.pay-ubq-fi.pages.dev/?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNTA3MjU2MTcyNzI2MzU2MTU0OTk1NjU0NDE0ODE0MDg1MDk0OTY4MTUwODI4MTcxMjQwNDM1NTUyNDAxMzM2ODYyNTM4MTUyNDM3NTQiLCJkZWFkbGluZSI6IjExNTc5MjA4OTIzNzMxNjE5NTQyMzU3MDk4NTAwODY4NzkwNzg1MzI2OTk4NDY2NTY0MDU2NDAzOTQ1NzU4NDAwNzkxMzEyOTYzOTkzNSJ9LCJ0cmFuc2ZlckRldGFpbHMiOnsidG8iOiIweGVmQzBlNzAxQTgyNDk0M2I0NjlhNjk0YUM1NjRBYTFlZkY3QWI3ZGQiLCJyZXF1ZXN0ZWRBbW91bnQiOiIwIn0sIm93bmVyIjoiMHhmMzlGZDZlNTFhYWQ4OEY2RjRjZTZhQjg4MjcyNzljZmZGYjkyMjY2Iiwic2lnbmF0dXJlIjoiMHg2ODJiYmVlOGNlMDg3Y2M0NGJlNzdkMjk0MzUyZjFhZGEzNWRlZGNmZWM1Yzk4NDE3ODg1MmI0ZTU2MmY1ZGUxMzQ0ZDljNTJlNWQ5M2FiZTEyNjBkOWYzMjU2N2I4YTA5YzY5OTEwZTM4MzFhMTkwMmY5MTE5ZTZiN2Q2ZDBhYTFjIiwibmV0d29ya0lkIjoxMDB9LHsidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiI5MDAwMDAwMDAwMDAwMDAwMDAwIn0sIm5vbmNlIjoiNDE3OTg2MDI4ODA3MjE5NTU4MDQ0MjcxNjAzNDY3NDM5MjA1MDkyMTU5MDk2MzkwNTcyODEyNDE5MTAxNTQzNTcxMTYwMDQyOTIzNSIsImRlYWRsaW5lIjoiMTE1NzkyMDg5MjM3MzE2MTk1NDIzNTcwOTg1MDA4Njg3OTA3ODUzMjY5OTg0NjY1NjQwNTY0MDM5NDU3NTg0MDA3OTEzMTI5NjM5OTM1In0sInRyYW5zZmVyRGV0YWlscyI6eyJ0byI6IjB4ZWZDMGU3MDFBODI0OTQzYjQ2OWE2OTRhQzU2NEFhMWVmRjdBYjdkZCIsInJlcXVlc3RlZEFtb3VudCI6IjkwMDAwMDAwMDAwMDAwMDAwMDAifSwib3duZXIiOiIweGYzOUZkNmU1MWFhZDg4RjZGNGNlNmFCODgyNzI3OWNmZkZiOTIyNjYiLCJzaWduYXR1cmUiOiIweDY4MmJiZWU4Y2UwODdjYzQ0YmU3N2QyOTQzNTJmMWFkYTM1ZGVkY2ZlYzVjOTg0MTc4ODUyYjRlNTYyZjVkZTEzNDRkOWM1MmU1ZDkzYWJlMTI2MGQ5ZjMyNTY3YjhhMDljNjk5MTBlMzgzMWExOTAyZjkxMTllNmI3ZDZkMGFhMWMiLCJuZXR3b3JrSWQiOjEwMH1d

@0x4007
Copy link
Member Author

0x4007 commented Oct 15, 2024

@rndquu maybe worth reviewing the merge as at least this was spotted to be incorrect.

@The-Gamer-01
Copy link

I think this issue only need to modify the style?

@0x4007
Copy link
Member Author

0x4007 commented Oct 16, 2024

Technically speaking, yes. However my hope is to cover all the potential problems from the merge. Basically I'm hoping that my colleague can review the merge and see if anything else might have slipped through unnoticed.

@rndquu rndquu self-assigned this Oct 16, 2024
Copy link
Contributor

ubiquity-os bot commented Oct 16, 2024

@rndquu the deadline is at Wed, Oct 16, 11:58 AM UTC

Copy link
Contributor

ubiquity-os bot commented Oct 18, 2024

 [ 6 UUSD ] 

@rndquu
Contributions Overview
ViewContributionCountReward
IssueTask16
ReviewComment20
Conversation Incentives
CommentFormattingRelevanceReward
Resolves https://github.com/ubiquity/pay.ubq.fi/issues/339I've…
2
content:
  content:
    p:
      score: 0
      elementCount: 4
    ul:
      score: 1
      elementCount: 1
    li:
      score: 0.5
      elementCount: 2
  result: 2
regex:
  wordCount: 44
  wordValue: 0
  result: 0
0.90
They do match. I've compared current [pay.css](https://github.co…
15
content:
  content:
    p:
      score: 0
      elementCount: 2
    a:
      score: 5
      elementCount: 3
  result: 15
regex:
  wordCount: 73
  wordValue: 0
  result: 0
0.70

 [ 45.0445 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification136.6
IssueComment22.5775
ReviewComment25.867
Conversation Incentives
CommentFormattingRelevanceReward
Needs to be restored as my fixes were clobbered in pay.css at ht…
12.2
content:
  content:
    p:
      score: 0
      elementCount: 6
    img:
      score: 5
      elementCount: 2
  result: 10
regex:
  wordCount: 38
  wordValue: 0.1
  result: 2.2
136.6
@rndquu maybe worth reviewing the merge as at least this was spo…
1
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 15
  wordValue: 0.1
  result: 1
0.750.75
Technically speaking, yes. However my hope is to cover all the p…
2.15
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 37
  wordValue: 0.1
  result: 2.15
0.851.8275
The brightness of the logo doesn't match the text, so this can't…
6.11
content:
  content:
    p:
      score: 0
      elementCount: 2
    img:
      score: 5
      elementCount: 1
  result: 5
regex:
  wordCount: 17
  wordValue: 0.1
  result: 1.11
0.55.555
Just make sure "fill: currentColor"
0.39
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 5
  wordValue: 0.1
  result: 0.39
0.80.312

 [ 0.12675 UUSD ] 

@The-Gamer-01
Contributions Overview
ViewContributionCountReward
IssueComment10.12675
Conversation Incentives
CommentFormattingRelevanceReward
I think this issue only need to modify the style?
0.71
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 10
  wordValue: 0.1
  result: 0.71
0.70.12675

@0x4007
Copy link
Member Author

0x4007 commented Oct 18, 2024

I think it might make sense to limit rewards to the assignee rewards.

@rndquu
Copy link
Member

rndquu commented Oct 18, 2024

I think it might make sense to limit rewards to the assignee rewards.

You mean adjusting the config or creating a new issue for it in https://github.com/ubiquity-os-marketplace/text-conversation-rewards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants