Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle large numbers in details table #335

Merged
merged 2 commits into from
Oct 14, 2024
Merged

feat: handle large numbers in details table #335

merged 2 commits into from
Oct 14, 2024

Conversation

zugdev
Copy link
Contributor

@zugdev zugdev commented Oct 14, 2024

Resolves #315

@zugdev zugdev requested a review from Keyrxng as a code owner October 14, 2024 20:41
@zugdev
Copy link
Contributor Author

zugdev commented Oct 14, 2024

qa-details.mp4

@ubiquity-os-deployer
Copy link

ubiquity-os-deployer bot commented Oct 14, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

Preview Deployment
fea4414ab8579c38138837d9844b04d1996b86fc
4c442e8bc22d022617739bcc44202a93fb1fa581

0x4007
0x4007 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine

@0x4007 0x4007 merged commit 320cd40 into ubiquity:development Oct 14, 2024
3 checks passed
@ubiquity-os ubiquity-os bot mentioned this pull request Oct 14, 2024
Closed
@zugdev
Copy link
Contributor Author

zugdev commented Oct 14, 2024

@0x4007 can you correct from quintillion to quadrillion? Comment is wrong, thanks.

@0x4007
Copy link
Member

0x4007 commented Oct 14, 2024

No im mobile you can open a pull and reference your comment

@rndquu rndquu mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4007 0x4007 0x4007 approved these changes

@Keyrxng Keyrxng Awaiting requested review from Keyrxng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allowance field in #additionalDetails
2 participants
@zugdev @0x4007