Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowance field in #additionalDetails #315

Closed
Keyrxng opened this issue Sep 24, 2024 · 10 comments · Fixed by #335
Closed

allowance field in #additionalDetails #315

Keyrxng opened this issue Sep 24, 2024 · 10 comments · Fixed by #335
Assignees
@zugdev
Labels
Price: 50 USD Priority: 2 (Medium) Time: <1 Hour

Comments

@Keyrxng
Copy link
Contributor

Keyrxng commented Sep 24, 2024

We have an overflow problem with the allowance field and it has lots of ways to handle it but with a couple of things to consider:

  • We need to be able to see the token extension
    image
  • We don't really care about decimals
  • Max approvals while rare and advised against they do still happen

image

  • Should we add handling to transform this value beyond a certain number to a more readable format such as anything after 100,000 becomes:
  • 100K WXDAI
  • 341K WXDAI
  • 1.2M WXDAI

We'll have the same overflow problem in the balance field and while it's v unlikely for stables etc but ERC20s will easily encounter issues with it so we should consider the applying the same handling to both.
Closed
@whck6
Copy link

whck6 commented Sep 25, 2024

/start

@0x4007
Copy link
Member

0x4007 commented Sep 25, 2024

@gentlementlegen can you write some more unit tests for start? Or was this exactly when we were setting up the new bot instance?

@ubiquity-os ubiquity-os
Copy link
Contributor

ubiquity-os bot commented Sep 25, 2024

@whck6 the deadline is at Wed, Sep 25, 8:36 PM UTC

@gentlementlegen
Copy link
Member

@0x4007 What do you mean? Given the current state of the bot, I do not now if it is a plugin issue or simply the kernel not running.

@ubiquity-os ubiquity-os
Copy link
Contributor

ubiquity-os bot commented Sep 30, 2024

@whck6, this task has been idle for a while. Please provide an update.

1 similar comment
@ubiquity-os ubiquity-os
Copy link
Contributor

ubiquity-os bot commented Oct 4, 2024

@whck6, this task has been idle for a while. Please provide an update.

@ubiquity-os ubiquity-os bot unassigned whck6 Oct 14, 2024
@zugdev
Copy link
Contributor

zugdev commented Oct 14, 2024

/start

@ubiquity-os ubiquity-os
Copy link
Contributor

ubiquity-os bot commented Oct 14, 2024

Deadline Mon, Oct 14, 8:49 PM UTC
Beneficiary 0xbB689fDAbBfc0ae9102863E011D3f897b079c80F

Tip

  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@zugdev zugdev mentioned this issue Oct 14, 2024
Merged
@ubiquity-os ubiquity-os
Copy link
Contributor

ubiquity-os bot commented Oct 14, 2024 •
edited
Loading

 [ 50 WXDAI ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueTask150
ReviewComment30
Conversation Incentives
CommentFormattingRelevanceReward
Resolves #315
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0
  result: 0
0.10
That's better
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0
  result: 0
0.60
https://github.com/user-attachments/assets/33c1bbc9-35b2-4beb-8f…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 11
  wordValue: 0
  result: 0
00

 [ 0.601 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment10.576
ReviewComment20.025
Conversation Incentives
CommentFormattingRelevanceReward
@gentlementlegen can you write some more unit tests for start? O…
1.44
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 23
  wordValue: 0.1
  result: 1.44
0.40.576
Code looks fine
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
0.10.025
```suggestionreturn "Unlimited"; // we can cons…
0
content:
  content: {}
  result: 0
regex:
  wordCount: 0
  wordValue: 0.1
  result: 0
0.80

 [ 0.51 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment10.51
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 What do you mean? Given the current state of the bot, I …
1.7
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 28
  wordValue: 0.1
  result: 1.7
0.30.51

 [ 66.69 WXDAI ] 

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueSpecification166.69
Conversation Incentives
CommentFormattingRelevanceReward
We have an overflow problem with the allowance field and it has …
22.23
content:
  content:
    p:
      score: 0
      elementCount: 10
    ul:
      score: 1
      elementCount: 3
    li:
      score: 0.5
      elementCount: 7
    img:
      score: 5
      elementCount: 2
    hr:
      score: 0
      elementCount: 1
  result: 16.5
regex:
  wordCount: 117
  wordValue: 0.1
  result: 5.73
166.69

@ubiquity-os ubiquity-os
Copy link
Contributor

ubiquity-os bot commented Oct 22, 2024 •
edited
Loading

 [ 50 UUSD ] 

@zugdev
Contributions Overview
ViewContributionCountReward
IssueTask150
ReviewComment40
Conversation Incentives
CommentFormattingRelevanceReward
Resolves #315
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 2
  wordValue: 0
  result: 0
0.10
That's better
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0
  result: 0
0.60
https://github.com/user-attachments/assets/33c1bbc9-35b2-4beb-8f…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 11
  wordValue: 0
  result: 0
00
@0x4007 can you correct from quintillion to quadrillion? Comment…
0
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 12
  wordValue: 0
  result: 0
0.80

 [ 0.709 UUSD ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment10.576
ReviewComment30.133
Conversation Incentives
CommentFormattingRelevanceReward
@gentlementlegen can you write some more unit tests for start? O…
1.44
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 23
  wordValue: 0.1
  result: 1.44
0.40.576
Code looks fine
0.25
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 3
  wordValue: 0.1
  result: 0.25
0.20.05
```suggestionreturn "Unlimited"; // we can cons…
0
content:
  content: {}
  result: 0
regex:
  wordCount: 0
  wordValue: 0.1
  result: 0
0.90
No im mobile you can open a pull and reference your comment
0.83
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 12
  wordValue: 0.1
  result: 0.83
0.10.083

 [ 1.02 UUSD ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment11.02
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 What do you mean? Given the current state of the bot, I …
1.7
content:
  content:
    p:
      score: 0
      elementCount: 1
  result: 0
regex:
  wordCount: 28
  wordValue: 0.1
  result: 1.7
0.61.02

 [ 66.69 UUSD ] 

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueSpecification166.69
Conversation Incentives
CommentFormattingRelevanceReward
We have an overflow problem with the allowance field and it has …
22.23
content:
  content:
    p:
      score: 0
      elementCount: 10
    ul:
      score: 1
      elementCount: 3
    li:
      score: 0.5
      elementCount: 7
    img:
      score: 5
      elementCount: 2
    hr:
      score: 0
      elementCount: 1
  result: 16.5
regex:
  wordCount: 117
  wordValue: 0.1
  result: 5.73
166.69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zugdev zugdev

Labels
Price: 50 USD Priority: 2 (Medium) Time: <1 Hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: handle large numbers in details table zugdev/pay.ubq.fi
5 participants
@0x4007 @whck6 @gentlementlegen @Keyrxng @zugdev