-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prop access and added test #231
fix: prop access and added test #231
Conversation
…into fix/invalidate-nonce
@rndquu all passing, the new setup scripts seem like they are doing the trick. Ofc it could still potentially fail but it's far less likely |
@gentlementlegen perhaps we should remove this feature because it doesn't work where it's needed. I was going to test the pull now but the link is invalid. Or if you can fix this that would be ideal. Alternatively we could create a "dev mode" menu on preview deployments to inject a permit. Perhaps we could generate it from the current active wallet so that we could also test invalidation etc. just a thought but also I'm a bit concerned that it's over engineered for the problem we are trying to solve (QA) Reopened #195 |
@0x4007 Sadly back to the problem with the env missing on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine
@Keyrxng Also thank you for your efforts with https://github.com/ubiquity/pay.ubq.fi/blob/03ac1d3f807b4e9ab32053d4b7f240c9587900d7/cypress/scripts/funding.ts, it helps a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran tests locally, all successful. My only remark would be that maybe http://localhost:8545
deserves to be stored in a variable, it seems to be used in plenty of places.
Resolves #227