Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit Invalidation Does Not Work #227

Closed
0x4007 opened this issue May 24, 2024 · 10 comments · Fixed by #231
Closed

Permit Invalidation Does Not Work #227

0x4007 opened this issue May 24, 2024 · 10 comments · Fixed by #231

Comments

@0x4007
Copy link
Member

0x4007 commented May 24, 2024

I tried invalidating a permit and got this error.

erc20-permit.ts:255 TypeError: Cannot read properties of undefined (reading 'nonce')
    at HTMLButtonElement.invalidateButtonClickHandler (erc20-permit.ts:251:57)
invalidateButtonClickHandler	@	erc20-permit.ts:255
Screenshot 2024-05-24 at 23 34 58
@Keyrxng
Copy link
Contributor

Keyrxng commented May 29, 2024

/start

Copy link

ubiquibot bot commented May 29, 2024

DeadlineWed, May 29, 3:16 AM UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquibot bot commented May 31, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented May 31, 2024

[ 40.8 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification113.2
ReviewComment127.6
Conversation Incentives
CommentFormattingRelevanceReward
I tried invalidating a permit and got this error.
erc20-...</a></h6></td><td><details><summary>13.2</summary>
<pre>code:
  count: 1
  score: "1"
  words: 0
</pre>
</details></td><td>1</td><td>13.2</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/231#issuecomment-2138158410">&gt; | Preview Deployment |
&gt; | ------------------ |
&gt; | [...</a></h6></td><td><details><summary>27.6</summary>
<pre>a:
  count: 2
  score: "4"
  words: 2
td:
  count: 2
  score: "4"
  words: 8
</pre>
</details></td><td>0.51</td><td>27.6</td></tr></tbody></table>
  </details>
  

  <details>
    <summary>
      <b
        ><h3>
          <a
            href="https://pay.ubq.fi/?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiI4MDAwMDAwMDAwMDAwMDAwMDAwIn0sIm5vbmNlIjoiNzU5MTg3MTM1NTI0NDc4MTIwMTM0MDc4NDU3NDY0MTU4OTM1OTU4MDgzNzQ4MDA4NTExOTE5NjExMTA2NTg3OTQ4NTI2MjUyNjQzODUiLCJkZWFkbGluZSI6IjExNTc5MjA4OTIzNzMxNjE5NTQyMzU3MDk4NTAwODY4NzkwNzg1MzI2OTk4NDY2NTY0MDU2NDAzOTQ1NzU4NDAwNzkxMzEyOTYzOTkzNSJ9LCJ0cmFuc2ZlckRldGFpbHMiOnsidG8iOiIweDBmQzFiOTA5YmE5MjY1QTg0NmI4MkNGNENFMzUyZmMzZTdFZUIyRUQiLCJyZXF1ZXN0ZWRBbW91bnQiOiI4MDAwMDAwMDAwMDAwMDAwMDAwIn0sIm93bmVyIjoiMHg0NENhMTVEYjEwMWZEMWMxOTQ0NjdEYjZBRjBjNjdDNkJiRjRBQjUxIiwic2lnbmF0dXJlIjoiMHgwYzViZmM3NzBlYzFhMzQ3YmFlNDQ4ZDk5NzAyNzUzMjhmMzNmNGNmM2Q0OTQ2NDU2MTQ2MThmZDZiZDc4N2MwNjgwM2I1ZDEwYzhkZTVkMjBiZGY3MTQ4ZjU0NTA4ODhmY2ExNjlhM2Q4ZGY3NmVlNjJiMDNjYzU0NTcyODJiMjFjIiwibmV0d29ya0lkIjoxMDB9XQ%3D%3D"
          >
            [ 8 WXDAI ]</a
          >
        </h3>
        <h6>@gentlementlegen</h6></b
      >
    </summary>
    <h6>Contributions Overview</h6>
<table><thead>
<tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th>
</thead><tbody>
<tr><td>Review</td><td>Comment</td><td>1</td><td>8</td></tr>
</tbody></table>
    <h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/231#issuecomment-2138566391">@0x4007 Sadly back to the problem with the env missing on `pull_...</a></h6></td><td><details><summary>8</summary>
<pre>code:
  count: 3
  score: "3"
  words: 3
</pre>
</details></td><td>0.59</td><td>8</td></tr></tbody></table>
  </details>
  

  <details>
    <summary>
      <b
        ><h3>
          <a
            href="https://pay.ubq.fi/?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIyMDQ0MDAwMDAwMDAwMDAwMDAwMDAifSwibm9uY2UiOiIxMDM1MTkzMzA4MDg5ODY2MDk4MjIyNzgxNDU0OTUyNzA5MjgwNTkyNDQ4NjEwMjM0OTI4NTkwNDUwNTcyMDIxNjAzMTU4ODQ2MjgzNDIiLCJkZWFkbGluZSI6IjExNTc5MjA4OTIzNzMxNjE5NTQyMzU3MDk4NTAwODY4NzkwNzg1MzI2OTk4NDY2NTY0MDU2NDAzOTQ1NzU4NDAwNzkxMzEyOTYzOTkzNSJ9LCJ0cmFuc2ZlckRldGFpbHMiOnsidG8iOiIweEFlNUQxRjE5MjAxM2RiODg5YjFlMjExNUEzNzBhQjEzM2YzNTk3NjUiLCJyZXF1ZXN0ZWRBbW91bnQiOiIyMDQ0MDAwMDAwMDAwMDAwMDAwMDAifSwib3duZXIiOiIweDQ0Q2ExNURiMTAxZkQxYzE5NDQ2N0RiNkFGMGM2N0M2QmJGNEFCNTEiLCJzaWduYXR1cmUiOiIweDJmMzNkMDgxMTJiNGI3YTEyOTFkNDlhODZhZjA5NzI2NDExYjAyZjg3NzQ2NDUzYjM3MWZhMjBlOTRkMjliYjM0ZmEzZGRiZjdhNzZhZWMwNTI2ZTdlM2VkOGE1NzRhNWM2ZjU3YWVmMWY1YjIyOWJhOTQ1M2E5YTczYWVlMWVkMWMiLCJuZXR3b3JrSWQiOjEwMH1d"
          >
            [ 204.4 WXDAI ]</a
          >
        </h3>
        <h6>@Keyrxng</h6></b
      >
    </summary>
    <h6>Contributions Overview</h6>
<table><thead>
<tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th>
</thead><tbody>
<tr><td>Issue</td><td>Task</td><td>1</td><td>200</td></tr>
<tr><td>Review</td><td>Comment</td><td>2</td><td>4.4</td></tr>
</tbody></table>
    <h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/231#issuecomment-2136373763">CI failed because of `nonce too low` again

![image](https://g...</a></h6></td><td><details><summary>1.8</summary>
<pre>code:
  count: 1
  score: "1"
  words: 3
</pre>
</details></td><td>0.75</td><td>1.8</td></tr><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/231#issuecomment-2137127659">@rndquu all passing, the new setup scripts seem like they are do...</a></h6></td><td>2.6</td><td>0.62</td><td>2.6</td></tr></tbody></table>
  </details>
  

  <details>
    <summary>
      <b
        ><h3>
          <a
            href="https://pay.ubq.fi/?claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIzMDAwMDAwMDAwMDAwMDAwMDAwIn0sIm5vbmNlIjoiMTAxNjI5MDIzMjY5MjQyNzY1ODE5MTEwNTUyMjgxNDk0Nzc3MzI0MTI3Nzc5MjA3OTA4MzY1OTc4NDkyOTg3OTU3MzE5MzE2ODQzMTI5IiwiZGVhZGxpbmUiOiIxMTU3OTIwODkyMzczMTYxOTU0MjM1NzA5ODUwMDg2ODc5MDc4NTMyNjk5ODQ2NjU2NDA1NjQwMzk0NTc1ODQwMDc5MTMxMjk2Mzk5MzUifSwidHJhbnNmZXJEZXRhaWxzIjp7InRvIjoiMHgzMzZDMDMzODQyRkEzMTZkNDcwZTgyMGM4MWI3NDJlNjJBMDc2NURDIiwicmVxdWVzdGVkQW1vdW50IjoiMzAwMDAwMDAwMDAwMDAwMDAwMCJ9LCJvd25lciI6IjB4NDRDYTE1RGIxMDFmRDFjMTk0NDY3RGI2QUYwYzY3QzZCYkY0QUI1MSIsInNpZ25hdHVyZSI6IjB4ZTdjMzk0NzE1NTA2ZmE3NDdkZTQ0YTkxYjdjYTJiMWVjZDdiZjQ5YTdmOWFjNTllZjM5OGUyOWY3MTdlMDg2YTExZmRmYWM1NDA0MDUzNjI2ZGFiNDljNDU0OGQyNjQ3ZDQ4MDI5MmJhZDJhYWRlNGU4YTMxY2JhN2Y3YzZhNGMxYyIsIm5ldHdvcmtJZCI6MTAwfV0%3D"
          >
            [ 3 WXDAI ]</a
          >
        </h3>
        <h6>@rndquu</h6></b
      >
    </summary>
    <h6>Contributions Overview</h6>
<table><thead>
<tr><th>View</th><th>Contribution</th><th>Count</th><th>Reward</th>
</thead><tbody>
<tr><td>Review</td><td>Comment</td><td>1</td><td>3</td></tr>
</tbody></table>
    <h6>Conversation Incentives</h6><table><thead><tr><th>Comment</th><th>Formatting</th><th>Relevance</th><th>Reward</th></tr></thead><tbody><tr><td><h6><a href="https://github.com/ubiquity/pay.ubq.fi/pull/231#issuecomment-2136713373">&gt; CI failed because of `nonce too low` again
&gt; 
&gt; ![i...</a></h6></td><td><details><summary>3</summary>
<pre>code:
  count: 2
  score: "2"
  words: 4
</pre>
</details></td><td>0.64</td><td>3</td></tr></tbody></table>
  </details>
  
<!-- Ubiquity - Transactions - generatePermits - 1ac4959
[
  {
    "permit": {
      "permitted": {
        "token": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d",
        "amount": "40800000000000000000"
      },
      "nonce": "57189395821398747034665612155937056615596790873765724558617517455198663965104",
      "deadline": "115792089237316195423570985008687907853269984665640564039457584007913129639935"
    },
    "transferDetails": {
      "to": "0x4007CE2083c7F3E18097aeB3A39bb8eC149a341d",
      "requestedAmount": "40800000000000000000"
    },
    "owner": "0x44Ca15Db101fD1c194467Db6AF0c67C6BbF4AB51",
    "signature": "0xc7812f66eaf0f2be6d7a265742f76c22ce6a0acc8e4f82d2d1b68895fd2fa49d10810dceb5c73703e20f43e5a83bf54addc128e70d5322ae2f6500a53924d3791c",
    "networkId": 100
  },
  {
    "permit": {
      "permitted": {
        "token": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d",
        "amount": "8000000000000000000"
      },
      "nonce": "75918713552447812013407845746415893595808374800851191961110658794852625264385",
      "deadline": "115792089237316195423570985008687907853269984665640564039457584007913129639935"
    },
    "transferDetails": {
      "to": "0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED",
      "requestedAmount": "8000000000000000000"
    },
    "owner": "0x44Ca15Db101fD1c194467Db6AF0c67C6BbF4AB51",
    "signature": "0x0c5bfc770ec1a347bae448d9970275328f33f4cf3d494645614618fd6bd787c06803b5d10c8de5d20bdf7148f5450888fca169a3d8df76ee62b03cc5457282b21c",
    "networkId": 100
  },
  {
    "permit": {
      "permitted": {
        "token": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d",
        "amount": "204400000000000000000"
      },
      "nonce": "103519330808986609822278145495270928059244861023492859045057202160315884628342",
      "deadline": "115792089237316195423570985008687907853269984665640564039457584007913129639935"
    },
    "transferDetails": {
      "to": "0xAe5D1F192013db889b1e2115A370aB133f359765",
      "requestedAmount": "204400000000000000000"
    },
    "owner": "0x44Ca15Db101fD1c194467Db6AF0c67C6BbF4AB51",
    "signature": "0x2f33d08112b4b7a1291d49a86af09726411b02f87746453b371fa20e94d29bb34fa3ddbf7a76aec0526e7e3ed8a574a5c6f57aef1f5b229ba9453a9a73aee1ed1c",
    "networkId": 100
  },
  {
    "permit": {
      "permitted": {
        "token": "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d",
        "amount": "3000000000000000000"
      },
      "nonce": "101629023269242765819110552281494777324127779207908365978492987957319316843129",
      "deadline": "115792089237316195423570985008687907853269984665640564039457584007913129639935"
    },
    "transferDetails": {
      "to": "0x336C033842FA316d470e820c81b742e62A0765DC",
      "requestedAmount": "3000000000000000000"
    },
    "owner": "0x44Ca15Db101fD1c194467Db6AF0c67C6BbF4AB51",
    "signature": "0xe7c394715506fa747de44a91b7ca2b1ecd7bf49a7f9ac59ef398e29f717e086a11fdfac5404053626dab49c4548d2647d480292bad2aade4e8a31cba7f7c6a4c1c",
    "networkId": 100
  }
]
-->

Copy link

[ 209.848 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 200
Review Comment 3 9.848
Conversation Incentives
Comment Formatting Relevance Reward
Resolves #227 - correct prop access typo - add test for invalid…
0
p:
  count: 13
  score: 1
0.79 -
CI failed because of `nonce too low` again ![image](https://gith…
4.4
p:
  count: 8
  score: 1
code:
  count: 3
  score: 1
img:
  count: 1
  score: 0
0.67 2.948
@rndquu all passing, the new setup scripts seem like they are do…
10
p:
  count: 25
  score: 1
0.69 6.9

[ 9.622 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Specification 1 3.888
Review Comment 1 5.734
Conversation Incentives
Comment Formatting Relevance Reward
I tried invalidating a permit and got this error. ``` erc20-perm…
4.8
p:
  count: 33
  score: 1
code:
  count: 15
  score: 1
0.81 3.888
@gentlementlegen perhaps we should remove this feature because …
9.4
p:
  count: 94
  score: 1
0.61 5.734

[ 1.731 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Review Comment 2 1.731
Conversation Incentives
Comment Formatting Relevance Reward
Works fine @Keyrxng Also thank you for your efforts with https:/…
1.5
p:
  count: 15
  score: 1
0.56 0.84
Could you merge the latest `development` branch and try again?
1.1
p:
  count: 10
  score: 1
code:
  count: 1
  score: 1
0.81 0.891

[ 6.206 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Review Comment 2 6.206
Conversation Incentives
Comment Formatting Relevance Reward
Ran tests locally, all successful. My only remark would be that …
3
p:
  count: 29
  score: 1
code:
  count: 1
  score: 1
0.63 1.89
@0x4007 Sadly back to the problem with the env missing on `pull_…
5.2
p:
  count: 49
  score: 1
code:
  count: 3
  score: 1
0.83 4.316

@rndquu rndquu reopened this May 31, 2024
Copy link

ubiquibot bot commented May 31, 2024

# These linked pull requests are closed:  <a href="https://github.com/ubiquity/pay.ubq.fi/pull/231">#231</a> 

Copy link

ubiquibot bot commented May 31, 2024

@Keyrxng the deadline is at 2024-05-31T10:39:42.168Z

@rndquu rndquu closed this as completed May 31, 2024
Copy link

ubiquibot bot commented May 31, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented May 31, 2024

[ 40.8 WXDAI ]

@0x4007
Contributions Overview
ViewContributionCountReward
IssueSpecification113.2
ReviewComment127.6
Conversation Incentives
CommentFormattingRelevanceReward
I tried invalidating a permit and got this error.

erc20-...

13.2

code:
  count: 1
  score: "1"
  words: 0
113.2
> | Preview Deployment | > | ------------------ | > | [...
27.6
a:
  count: 2
  score: "4"
  words: 2
td:
  count: 2
  score: "4"
  words: 8
0.4427.6

[ 8 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
ReviewComment18
Conversation Incentives
CommentFormattingRelevanceReward
@0x4007 Sadly back to the problem with the env missing on `pull_...
8
code:
  count: 3
  score: "3"
  words: 3
0.578

[ 204.4 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueTask1200
ReviewComment24.4
Conversation Incentives
CommentFormattingRelevanceReward
CI failed because of `nonce too low` again

![image](https://g...

1.8

code:
  count: 1
  score: "1"
  words: 3
0.671.8
@rndquu all passing, the new setup scripts seem like they are do...
2.60.682.6

[ 3 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment13
Conversation Incentives
CommentFormattingRelevanceReward
> CI failed because of `nonce too low` again > > ![i...
3
code:
  count: 2
  score: "2"
  words: 4
0.563

Copy link

[ 209.08 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 200
Review Comment 3 9.08
Conversation Incentives
Comment Formatting Relevance Reward
Resolves #227 - correct prop access typo - add test for invalid…
0
p:
  count: 13
  score: 1
0.79 -
CI failed because of `nonce too low` again ![image](https://gith…
4.4
p:
  count: 8
  score: 1
code:
  count: 3
  score: 1
img:
  count: 1
  score: 0
0.7 3.08
@rndquu all passing, the new setup scripts seem like they are do…
10
p:
  count: 25
  score: 1
0.6 6

[ 9.95 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Specification 1 3.84
Review Comment 1 6.11
Conversation Incentives
Comment Formatting Relevance Reward
I tried invalidating a permit and got this error. ``` erc20-perm…
4.8
p:
  count: 33
  score: 1
code:
  count: 15
  score: 1
0.8 3.84
@gentlementlegen perhaps we should remove this feature because …
9.4
p:
  count: 94
  score: 1
0.65 6.11

[ 1.716 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Review Comment 2 1.716
Conversation Incentives
Comment Formatting Relevance Reward
Works fine @Keyrxng Also thank you for your efforts with https:/…
1.5
p:
  count: 15
  score: 1
0.55 0.825
Could you merge the latest `development` branch and try again?
1.1
p:
  count: 10
  score: 1
code:
  count: 1
  score: 1
0.81 0.891

[ 6.214 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Review Comment 2 6.214
Conversation Incentives
Comment Formatting Relevance Reward
Ran tests locally, all successful. My only remark would be that …
3
p:
  count: 29
  score: 1
code:
  count: 1
  score: 1
0.65 1.95
@0x4007 Sadly back to the problem with the env missing on `pull_…
5.2
p:
  count: 49
  score: 1
code:
  count: 3
  score: 1
0.82 4.264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants