fix: update config types to match the new bot config #154

gentlementlegen · 2024-02-13T08:08:09Z

Resolves #135

0x4007

I realized we didn't clearly document something that is crucial for you to know. The production deployment of the bot is actually in a totally different/unexpected place because we were in a rush to demo it for some conference a few months ago. It's on my fork and its on the latest branch there which I have to find again (or on desktop you can see the latest branches)

I still need to merge it back in but at the same time we started work on redoing the architecture completely to "kernel-plugin" style over at ubiquibot-kernel repo under ubiquity organization.

The net result is that we plan to prototype the event handlers in this monolithic repository since it's semi functional and then port them over into separate plugins to interface with the kernel when it's stable.

0x4007 · 2024-02-13T12:47:44Z

.gitmodules

@@ -5,3 +5,7 @@
 [submodule "lib/permit2"]
 	path = lib/permit2
 	url = https://github.com/Uniswap/permit2
+[submodule "lib/ubiquibot"]


Smart way to share types!

0x4007 · 2024-02-13T12:52:21Z

Here is the latest branch that is currently powering the netlify production deployment.

https://github.com/pavlovcik/ubiquibot/tree/refactor/move-to-delegated-compute

P.S. another reason why we are redoing the architecture is to be compatible with the Cloudflare Worker runtime.

Sorry for not clearly telling you about this before you dove into the development branch here!

gentlementlegen · 2024-02-13T13:41:29Z

I realized we didn't clearly document something that is crucial for you to know. The production deployment of the bot is actually in a totally different/unexpected place because we were in a rush to demo it for some conference a few months ago. It's on my fork and its on the latest branch there which I have to find again (or on desktop you can see the latest branches)

I still need to merge it back in but at the same time we started work on redoing the architecture completely to "kernel-plugin" style over at ubiquibot-kernel repo under ubiquity organization.

The net result is that we plan to prototype the event handlers in this monolithic repository since it's semi functional and then port them over into separate plugins to interface with the kernel when it's stable.

@pavlovcik all good, I am myself not very familiar yet with the whole architecture so I serve as monkey tester for now. I'll move to the other branch and see what's going on, and update the PR accordingly.

0x4007 · 2024-02-14T05:09:34Z

static/scripts/onboarding/onboarding.ts

@@ -131,10 +49,10 @@ export const parseYAML = async (data: any): Promise<any | undefined> => {
  }
 };

-export const parseJSON = async (data: any): Promise<any | undefined> => {
+export const parseJSON = async <T>(data: string) => {


Seems like a wise way to set up types.

0x4007 · 2024-02-14T05:11:10Z

I'll have @rndquu handle the real review.

static/scripts/onboarding/onboarding.ts

rndquu

Getting an error on start and the "Set" button doesn't do anything then

gentlementlegen · 2024-02-14T09:26:54Z

Getting an error on start and the "Set" button doesn't do anything then

It seems that the url is pointing to the conf file that moved, I will take a look at it tomorrow. Also since it's completely different from what @pavlovcik might have to change the whole system altogether 😞

gentlementlegen · 2024-02-15T04:50:57Z

So after looking into it, I think this should be broke down in more steps. First we should use the old ubiquibot conf to solve this issue, which was to remove all the any and use the .ts configuration defaults. Then, the current bot (the one under pavlovcik repo) should be changed in a way that the conf works differently and can easily be embedded in other projects. I believe it should be a separate task.
@rndquu you should be able to run it locally now

…bmodule

0x4007 · 2024-02-15T06:37:40Z

static/scripts/onboarding/onboarding.ts

-      conf = JSON.parse(conf);
-      defaultConf = conf as IConf;
-      defaultConf["private-key-encrypted"] = "";
+      defaultConf[PRIVATE_ENCRYPTED_KEY_NAME] = "";


I am pretty sure that we changed our strategy to be either null or the correct string for these situations.

Changed it to undefined (type is string | undefined with the current conf from Ubiqubot repo)

I prefer null as it is unambiguously empty vs undefined which could be a mistake. Why did you choose undefined?

I didn't, it comes from the types in ubiquibot-config-default.ts

0x4007 · 2024-02-15T06:42:19Z

I think that you should be based off of my branch and then work off of my fork instead actually. This code is very much out of date.

We also eventually need to sync it back over to this repository. Perhaps you can help with this to avoid this confusion in the future with new contributors.

We also generally do not allow force pushes (accidentally left it on for this repository apparently)

gentlementlegen · 2024-02-15T07:39:51Z

@pavlovcik sure I would like to update the code but it would require refractor on both repositories which I thought would be out of scope for this ticket specifically. The other thread we have about how to change the configuration to be more easily sharable between projects should solve that issue later on.
Sorry for the force push, it was simply to revert the latest push with the change to link the submodule to your repo, will keep that in mind for later on!

0x4007 · 2024-02-15T08:09:11Z

would require refractor on both repositories which I thought would be out of scope for this ticket specifically. The other thread we have about how to change the configuration to be more easily sharable between projects should solve that issue later on.

Please feel free to file the issues and you can receive credit for writing those issue specifications assuming those tasks get funded! In this way, if somebody else has extra bandwidth, they might be able to help you proceed in parallel.

static/scripts/onboarding/onboarding.ts

rndquu

The build is failing, could you fix it?

gentlementlegen · 2024-02-15T16:27:11Z

The build is failing, could you fix it?

I added the submodule checkout in the build steps, I don't know how they were checked out before.

static/scripts/onboarding/onboarding.ts

0x4007 · 2024-02-16T05:35:07Z

static/scripts/onboarding/onboarding.ts

  } catch (error) {
    return undefined;
  }
 };

 export const YAMLStringify = (value: any) => YAML.stringify(value, { defaultKeyType: "PLAIN", defaultStringType: "QUOTE_DOUBLE", lineWidth: 0 });

-export const getConf = async (initial: boolean = false): Promise<string | undefined> => {
+export const getConf = async (): Promise<string | undefined> => {


I guess I need to update the lint settings after this is merged. I banned these arrow functions in favor of named functions (unless they are in a callback.)

0x4007

Just have one hangup related to the X25519 public key.

For context, this allows us to add the funding wallet's private key inside of the public .yml file, while only letting the bot decrypt it (we have the X25519 private key in our secrets.)

https://github.com/ubiquibot/comment-incentives/?tab=readme-ov-file#generating-a-new-evmprivatekeyencrypted

In other news, given that we figured out how to authenticate requests as the bot, wouldn't it make sense for us to read the raw key directly from their organization/repository secrets? Then we no longer need to include sensitive data inside of these public yml files. https://chat.openai.com/share/ba4e137d-4882-4c7a-b23a-2fcb541c83fb

rfc @rndquu @whilefoo

rndquu · 2024-02-16T09:58:38Z

The build is failing, could you fix it?

I added the submodule checkout in the build steps, I don't know how they were checked out before.

They were not. Since https://github.com/foundry-rs/forge-std and https://github.com/Uniswap/permit2 were not used in the frontend build process (only in solidity tests) there were no errors.

In other news, given that we figured out how to authenticate requests as the bot, wouldn't it make sense for us to read the raw key directly from their organization/repository secrets?

I am not really aware of the latest bot'a architecture, but, yes, if we pass wallet private key to some script in the github workflow file then we can stop saving encrypted evm private keys in yml files.

gentlementlegen · 2024-02-17T03:36:06Z

Is there any action I should take about this?

0x4007 · 2024-02-17T04:13:10Z

Is there any action I should take about this?

Can you make it based off of my fork and latest branch for now? We can handle merging mine in to the ubiquibot repository later

gentlementlegen · 2024-02-17T04:20:57Z

@pavlovcik Yes I can, but then this PR should just be deleted because everything should be changed to match your fork / branch I believe

0x4007 · 2024-02-17T04:23:12Z

That was my concern I voiced several days ago. Providing updates based on severely outdated code will not do us much good!

It may be best for you to focus efforts on the kernel instead if you want to work on the bot itself!

@rndquu rfc

gentlementlegen · 2024-02-17T04:41:14Z

@pavlovcik Yep you're right, I just thought we could do it step by step so we can merge this then I work on the config sharing from your branch, then later merge everything together, because it seems critical to have the code base updated on the main repo

rndquu · 2024-02-17T14:15:36Z

I just thought we could do it step by step

+1

The PR looks good, so I would merge it and let @FernandVEYRIER proceed with "merge this then I work on the config sharing from your branch, then later merge everything together"

gentlementlegen · 2024-02-17T15:00:10Z

Thanks @rndquu. Currently working on the bot npm package config, which should hopefully fix this problem later on by simply adding the package!

0x4007 · 2024-02-19T22:54:40Z

@FernandVEYRIER

Currently debugging a build error so that we can use the new continuous deployment I worked on all night:

m1:pay.ubq.fi nv$ git submodule update --init --recursive
fatal: transport 'file' not allowed
fatal: Fetched in submodule path 'lib/ubiquibot', but it did not contain 8afd7cfa13e9731fb49b5f5a03f605258458d649. Direct fetching of that commit failed.
m1:pay.ubq.fi nv$

Any ideas? I'm here: https://github.com/ubiquity/pay.ubq.fi/actions/runs/7966008208/job/21746567166

Update:

Those files don't exist anymore!

Related: #154

0x4007 · 2024-02-19T23:20:56Z

Got it 2c2b773#commitcomment-138808269

gentlementlegen added 3 commits February 12, 2024 20:33

feat: type pulled from gitmodule bot repository

bbf9660

chore: renamed conf keys to match the new bot conf

344c81d

chore: set private key to empty string to init conf

b556272

gentlementlegen marked this pull request as ready for review February 13, 2024 08:10

gentlementlegen requested review from 0x4007 and rndquu as code owners February 13, 2024 08:10

0x4007 reviewed Feb 13, 2024

View reviewed changes

gentlementlegen requested a review from 0x4007 February 14, 2024 03:34

0x4007 reviewed Feb 14, 2024

View reviewed changes

static/scripts/onboarding/onboarding.ts Show resolved Hide resolved

rndquu requested changes Feb 14, 2024

View reviewed changes

chore: removed default conf fetch as it is already imported in the su…

baf6f8d

…bmodule

gentlementlegen force-pushed the development branch from d002b0a to baf6f8d Compare February 15, 2024 05:06

gentlementlegen requested review from rndquu and 0x4007 February 15, 2024 05:07

0x4007 reviewed Feb 15, 2024

View reviewed changes

chore: changed privateKeyEncrypted to be undefined by default

ef0b7b3

rndquu requested changes Feb 15, 2024

View reviewed changes

static/scripts/onboarding/onboarding.ts Show resolved Hide resolved

static/scripts/onboarding/onboarding.ts Show resolved Hide resolved

static/scripts/onboarding/onboarding.ts Show resolved Hide resolved

gentlementlegen added 2 commits February 15, 2024 17:32

chore: added back safe-address

24618d6

chore: removed unused constants

3819fb9

rndquu requested changes Feb 15, 2024

View reviewed changes

chore: removed unused safe-address

41006a2

chore: submodule checkout

6c9239a

gentlementlegen requested review from 0x4007 and rndquu February 15, 2024 16:27

0x4007 reviewed Feb 16, 2024

View reviewed changes

static/scripts/onboarding/onboarding.ts Show resolved Hide resolved

0x4007 reviewed Feb 16, 2024

View reviewed changes

0x4007 mentioned this pull request Feb 16, 2024

Deprecate keys in config (evmPrivateKeyEncrypted, openAi) ubiquity-os/ubiquity-os-kernel#22

Closed

rndquu approved these changes Feb 17, 2024

View reviewed changes

0x4007 merged commit dcac7ae into ubiquity:development Feb 17, 2024
1 check passed

ubiquibot bot mentioned this pull request Feb 17, 2024

Onboarding updates #135

Closed

0x4007 added a commit that referenced this pull request Feb 19, 2024

fix: updated types

3c59ca0

Related: #154

molecula451 mentioned this pull request Mar 1, 2024

refactor: onboard.ubq.fi ubiquity/onboard.ubq.fi#1

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update config types to match the new bot config #154

fix: update config types to match the new bot config #154

gentlementlegen commented Feb 13, 2024

0x4007 left a comment •

edited

Loading

0x4007 Feb 13, 2024

0x4007 commented Feb 13, 2024 •

edited

Loading

gentlementlegen commented Feb 13, 2024

0x4007 Feb 14, 2024

0x4007 commented Feb 14, 2024

rndquu left a comment

gentlementlegen commented Feb 14, 2024

gentlementlegen commented Feb 15, 2024 •

edited

Loading

0x4007 Feb 15, 2024

gentlementlegen Feb 15, 2024

0x4007 Feb 15, 2024

gentlementlegen Feb 15, 2024

0x4007 commented Feb 15, 2024 •

edited

Loading

gentlementlegen commented Feb 15, 2024

0x4007 commented Feb 15, 2024 •

edited

Loading

rndquu left a comment

gentlementlegen commented Feb 15, 2024

0x4007 Feb 16, 2024

0x4007 left a comment •

edited

Loading

rndquu commented Feb 16, 2024

gentlementlegen commented Feb 17, 2024

0x4007 commented Feb 17, 2024

gentlementlegen commented Feb 17, 2024

0x4007 commented Feb 17, 2024 •

edited

Loading

gentlementlegen commented Feb 17, 2024

rndquu commented Feb 17, 2024

gentlementlegen commented Feb 17, 2024

0x4007 commented Feb 19, 2024 •

edited

Loading

0x4007 commented Feb 19, 2024

fix: update config types to match the new bot config #154

fix: update config types to match the new bot config #154

Conversation

gentlementlegen commented Feb 13, 2024

0x4007 left a comment • edited Loading

Choose a reason for hiding this comment

0x4007 Feb 13, 2024

Choose a reason for hiding this comment

0x4007 commented Feb 13, 2024 • edited Loading

gentlementlegen commented Feb 13, 2024

0x4007 Feb 14, 2024

Choose a reason for hiding this comment

0x4007 commented Feb 14, 2024

rndquu left a comment

Choose a reason for hiding this comment

gentlementlegen commented Feb 14, 2024

gentlementlegen commented Feb 15, 2024 • edited Loading

0x4007 Feb 15, 2024

Choose a reason for hiding this comment

gentlementlegen Feb 15, 2024

Choose a reason for hiding this comment

0x4007 Feb 15, 2024

Choose a reason for hiding this comment

gentlementlegen Feb 15, 2024

Choose a reason for hiding this comment

0x4007 commented Feb 15, 2024 • edited Loading

gentlementlegen commented Feb 15, 2024

0x4007 commented Feb 15, 2024 • edited Loading

rndquu left a comment

Choose a reason for hiding this comment

gentlementlegen commented Feb 15, 2024

0x4007 Feb 16, 2024

Choose a reason for hiding this comment

0x4007 left a comment • edited Loading

Choose a reason for hiding this comment

rndquu commented Feb 16, 2024

gentlementlegen commented Feb 17, 2024

0x4007 commented Feb 17, 2024

gentlementlegen commented Feb 17, 2024

0x4007 commented Feb 17, 2024 • edited Loading

gentlementlegen commented Feb 17, 2024

rndquu commented Feb 17, 2024

gentlementlegen commented Feb 17, 2024

0x4007 commented Feb 19, 2024 • edited Loading

0x4007 commented Feb 19, 2024

0x4007 left a comment •

edited

Loading

0x4007 commented Feb 13, 2024 •

edited

Loading

gentlementlegen commented Feb 15, 2024 •

edited

Loading

0x4007 commented Feb 15, 2024 •

edited

Loading

0x4007 commented Feb 15, 2024 •

edited

Loading

0x4007 left a comment •

edited

Loading

0x4007 commented Feb 17, 2024 •

edited

Loading

0x4007 commented Feb 19, 2024 •

edited

Loading