Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate keys in config (evmPrivateKeyEncrypted, openAi) #22

Closed
0x4007 opened this issue Feb 16, 2024 · 5 comments
Closed

Deprecate keys in config (evmPrivateKeyEncrypted, openAi) #22

0x4007 opened this issue Feb 16, 2024 · 5 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Feb 16, 2024

Given that we figured out how to authenticate requests as the bot, wouldn't it make sense for us to read the raw key directly from their organization/repository secrets? Then we no longer need to include sensitive data inside of these public yml files. https://chat.openai.com/share/ba4e137d-4882-4c7a-b23a-2fcb541c83fb

rfc @rndquu @whilefoo

Originally posted by @pavlovcik in ubiquity/pay.ubq.fi#154 (review)

@0x4007
Copy link
Member Author

0x4007 commented Feb 17, 2024

evmPrivateKeyEncrypted - I researched GitHub App permissions and its a boolean for all organization secrets or none; or all repository secrets or none. I think that partners may be weary to share ALL secrets so perhaps it makes sense to proceed with the X25519 evmPrivateKeyEncrypted system.

@0x4007 0x4007 closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2024
Copy link

ubiquibot bot commented Feb 17, 2024

# Issue was not closed as completed. Skipping.

@0x4007
Copy link
Member Author

0x4007 commented Feb 18, 2024

evmPrivateKeyEncrypted - I researched GitHub App permissions and its a boolean for all organization secrets or none; or all repository secrets or none. I think that partners may be weary to share ALL secrets so perhaps it makes sense to proceed with the X25519 evmPrivateKeyEncrypted system.

PSA @ubiquity/software-development

@molecula451
Copy link
Contributor

sense to proceed with the X25519 evmPrivateKeyEncrypted system.

What do you mean by proceed pavlovcik? proceed in removing the system?

@0x4007
Copy link
Member Author

0x4007 commented Feb 18, 2024

Let's continue using the system.

0x4007 added a commit to 0x4007/ubiquity-os-kernel that referenced this issue Mar 6, 2024
…fault-conf

feat: cypress default configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants