refactor: downgrade to ethers@v5 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Sep 16, 2024
Keyrxng
reviewed
Sep 21, 2024
There was a problem hiding this comment.
Most of the changes generally look fine
I agree if anything was wrong with the downgrade the tests would have broken, can't really QA it much beyond that unless going the extra mile and testing it against the various overloads or using it to generate a permit (I don't think I've ever actually generated a QA permit before in any repo other than pay.ubq.fi and it uses it's own script, not this pkg. My attempts to QA conversation rewards all fail at the point of permit generation too so)
|
@0x4007 is this good to merge? |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #60
I had to refactor a couple functions in
generate-erc20-permit.tsdue to issues with cognitive complexity, specifically I created three new functionsgetPrivateKeygetAdminWalletandgetTokenDecimalsI also had to include a yarn packageManager version in
package.jsonbecause it wasn't letting me commit otherwise. let me know if you want the yarn version changed, I used whatever version corepack set.