Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to Ethers@v5 #60

Closed
Keyrxng opened this issue Sep 7, 2024 · 27 comments · Fixed by #70
Closed

Downgrade to Ethers@v5 #60

Keyrxng opened this issue Sep 7, 2024 · 27 comments · Fixed by #70

Comments

@Keyrxng
Copy link
Contributor

Keyrxng commented Sep 7, 2024

This repo I think is the only one which is using Ethers@v6 and it would be best if the package was downgraded and any affected logic be refactored to work with V5

@hydroxylase
Copy link

/start

Copy link

ubiquity-os bot commented Sep 7, 2024

DeadlineSat, Sep 7, 2:44 PM UTC
Registered Wallet 0x229674f3db146E0AF0182b660F5c9232538E7e7b
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@hydroxylase
Copy link

/stop

Copy link

ubiquity-os bot commented Sep 7, 2024

# You have been unassigned from the task

@hydroxylase
Copy link

/start

Copy link

ubiquity-os bot commented Sep 7, 2024

DeadlineSat, Sep 7, 4:29 PM UTC
Registered Wallet 0x229674f3db146E0AF0182b660F5c9232538E7e7b
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@hydroxylase
Copy link

/stop

Copy link

ubiquity-os bot commented Sep 7, 2024

# You have been unassigned from the task

@hydroxylase
Copy link

/start

Copy link

ubiquity-os bot commented Sep 7, 2024

DeadlineSat, Sep 7, 6:33 PM UTC
Registered Wallet 0x229674f3db146E0AF0182b660F5c9232538E7e7b
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@hydroxylase
Copy link

/stop

Copy link

ubiquity-os bot commented Sep 7, 2024

# You have been unassigned from the task

@hydroxylase
Copy link

/start

Copy link

ubiquity-os bot commented Sep 7, 2024

DeadlineSat, Sep 7, 8:24 PM UTC
Registered Wallet 0x229674f3db146E0AF0182b660F5c9232538E7e7b
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Copy link

ubiquity-os bot commented Sep 13, 2024

@CaptainPrinz, this task has been idle for a while. Please provide an update.

@hydroxylase
Copy link

i really cant figure out why its failing

@hydroxylase hydroxylase removed their assignment Sep 14, 2024
@obeys
Copy link
Contributor

obeys commented Sep 15, 2024

/start

@0x4007
Copy link
Member

0x4007 commented Sep 16, 2024

/start

@gentlementlegen another start failure

@gentlementlegen
Copy link
Member

gentlementlegen commented Sep 16, 2024

@Keyrxng rfc

We don't have backlogs for this so it's quite hard to debug. Maybe it is due to the self un-assignment. Also assigning manually should have triggered a display of the deadline.


The error is the following

{
"logs": [
    {
      "message": [
        "Error: Unable to decode value as it does not match the expected schema"
      ],
      "level": "error",
      "timestamp": 1726450747927
    }
  ],
}

will investigate.

@gentlementlegen gentlementlegen assigned obeys and unassigned obeys Sep 16, 2024
@0x4007
Copy link
Member

0x4007 commented Sep 16, 2024

Same problem I had all day the other day when working on the plugin, so maybe I broke something environment related on the production deployment somehow by making a new cloudflare account.

This error message needs to be more specific.

@gentlementlegen
Copy link
Member

gentlementlegen commented Sep 16, 2024

It appears to me that the logic to decode the schema is wrong, and this would be introduced by Jordan's PR addition regarding the configuration accepting the amount of parallel tasks allowed for each user. If not provided, the default configuration fails which is why it is failing in your last try, on ubiquity / ubiquibot orgs, but not on mine where I provide the full config. Working on a fix right now. See ubiquity-os-marketplace/command-start-stop#51

@0x4007
Copy link
Member

0x4007 commented Sep 16, 2024

You should start by reverting his pull, reopening the issue, and then take your time with the fix

Copy link

ubiquity-os bot commented Sep 20, 2024

@cohow, this task has been idle for a while. Please provide an update.

@obeys
Copy link
Contributor

obeys commented Sep 20, 2024

Completed just waiting on code review.

Copy link

ubiquity-os bot commented Sep 23, 2024

@cohow, this task has been idle for a while. Please provide an update.

1 similar comment
Copy link

ubiquity-os bot commented Sep 27, 2024

@cohow, this task has been idle for a while. Please provide an update.

Copy link

ubiquity-os bot commented Sep 28, 2024

 [ 25.092 WXDAI ] 

@cohow
Contributions Overview
ViewContributionCountReward
IssueTask125
IssueComment10.092
ReviewComment40
Conversation Incentives
CommentFormattingRelevanceReward
Completed just waiting on code review.
0.46
content:
  p:
    symbols:
      \b\w+\b:
        count: 6
        multiplier: 0.1
    score: 1
multiplier: 1
0.20.092
Resolves #60I had to refactor a couple functions in `gener…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 57
        multiplier: 0
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 9
        multiplier: 0
    score: 1
multiplier: 0
0.7-
yarn 1.21 works as well, I'm not sure why it did that to me but …
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 31
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 12
        multiplier: 0.2
    score: 1
multiplier: 0
0.4-
changing yarn versions to `1.12.1` seems to have fixed t…
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 20
        multiplier: 0.2
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 5
        multiplier: 0.2
    score: 1
multiplier: 0
0.5-
@0x4007 is this good to merge?
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 6
        multiplier: 0.2
    score: 1
multiplier: 0
0.2-

 [ 0 WXDAI ] 

@hydroxylase
Contributions Overview
ViewContributionCountReward
IssueComment10
Conversation Incentives
CommentFormattingRelevanceReward
i really cant figure out why its failing
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 8
        multiplier: 0.1
    score: 1
multiplier: 0.25
--

 [ 0.791 WXDAI ] 

@0x4007
Contributions Overview
ViewContributionCountReward
IssueComment30.327
ReviewComment40.464
Conversation Incentives
CommentFormattingRelevanceReward
@gentlementlegen another start failure
0.08
content:
  p:
    symbols:
      \b\w+\b:
        count: 4
        multiplier: 0.1
    score: 1
multiplier: 0.25
0.10.008
Same problem I had all day the other day when working on the plu…
0.58
content:
  p:
    symbols:
      \b\w+\b:
        count: 40
        multiplier: 0.1
    score: 1
multiplier: 0.25
0.30.174
You should start by reverting his pull, reopening the issue, and…
0.29
content:
  p:
    symbols:
      \b\w+\b:
        count: 18
        multiplier: 0.1
    score: 1
multiplier: 0.25
0.50.145
Most of the changes generally look fine
0.13
content:
  p:
    symbols:
      \b\w+\b:
        count: 7
        multiplier: 0.1
    score: 1
multiplier: 0.25
0.20.026
Let's test in production!
0
content:
  p:
    symbols:
      \b\w+\b:
        count: 5
        multiplier: 0.1
    score: 1
multiplier: 0.25
--
What if you used yarn 1.21? I believe I have this version and 1.…
0.45
content:
  p:
    symbols:
      \b\w+\b:
        count: 30
        multiplier: 0.1
    score: 1
multiplier: 0.25
0.70.315
I never had this problem so I can't help you. Try reinitializin…
0.41
content:
  p:
    symbols:
      \b\w+\b:
        count: 27
        multiplier: 0.1
    score: 1
multiplier: 0.25
0.30.123

 [ 2.018 WXDAI ] 

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueComment22.018
Conversation Incentives
CommentFormattingRelevanceReward
@Keyrxng rfcWe don't have backlogs for this so it's quite hard…
3.67
content:
  p:
    symbols:
      \b\w+\b:
        count: 43
        multiplier: 0.1
    score: 1
  hr:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 0
  pre:
    symbols:
      \b\w+\b:
        count: 1
        multiplier: 0.1
    score: 0
  code:
    symbols:
      \b\w+\b:
        count: 19
        multiplier: 0.1
    score: 1
multiplier: 1
0.20.734
It appears to me that the logic to decode the schema is wrong, a…
4.28
content:
  p:
    symbols:
      \b\w+\b:
        count: 83
        multiplier: 0.1
    score: 1
multiplier: 1
0.31.284

 [ 9.68 WXDAI ] 

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueSpecification19.22
ReviewComment10.46
Conversation Incentives
CommentFormattingRelevanceReward
This repo I think is the only one which is using `Ethers@v6&…
9.22
content:
  p:
    symbols:
      \b\w+\b:
        count: 30
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.1
    score: 5
multiplier: 3
19.22
I agree if anything was wrong with the downgrade the tests would…
1.15
content:
  p:
    symbols:
      \b\w+\b:
        count: 85
        multiplier: 0.1
    score: 1
  code:
    symbols:
      \b\w+\b:
        count: 3
        multiplier: 0.1
    score: 1
multiplier: 0.25
0.40.46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment