Skip to content
This repository has been archived by the owner on Oct 9, 2024. It is now read-only.

feat!: update configuration #9

Merged
merged 16 commits into from
May 2, 2024
Merged

feat!: update configuration #9

merged 16 commits into from
May 2, 2024

Conversation

gentlementlegen
Copy link
Member

Resolves #8

@gentlementlegen gentlementlegen marked this pull request as ready for review April 24, 2024 14:23
@gentlementlegen
Copy link
Member Author

Main changes:

  • updated the configuration to match the V2 new configuration for the bot
  • moved dependencies to peer dependencies since this library is meant to be included inside others and not on its own (saved 200kb as well in the bundle)
  • updated the tests and package version accordingly

gitcoindev
gitcoindev suggested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@gitcoindev gitcoindev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments to add documentation but in general a good job!

.github/ubiquibot-config.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/types/configuration/github-comment-config.ts Show resolved Hide resolved
@gitcoindev
Copy link
Contributor

@gentlementlegen I noticed Jests tests are failing, please look into this as well https://github.com/ubiquibot/configuration/actions/runs/8826720734/job/24232850716?pr=9

@gentlementlegen
Copy link
Member Author

@gentlementlegen I noticed Jests tests are failing, please look into this as well https://github.com/ubiquibot/configuration/actions/runs/8826720734/job/24232850716?pr=9

@gitcoindev Tests are fixed and I should have addressed all your comments
https://github.com/ubiquibot/configuration/actions/runs/8845050329/job/24288169884

@gentlementlegen gentlementlegen merged commit 4382ea4 into ubiquity-os:development May 2, 2024
2 checks passed
@gentlementlegen gentlementlegen deleted the feat/update-configuration branch May 2, 2024 11:06
@ubiquibot ubiquibot bot mentioned this pull request May 2, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gitcoindev gitcoindev gitcoindev approved these changes

@molecula451 molecula451 Awaiting requested review from molecula451

@0x4007 0x4007 Awaiting requested review from 0x4007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change configuration for v2 of Ubiquibot
3 participants
@gentlementlegen @gitcoindev @0x4007