fix: undefined configuration

README.md

@@ -46,7 +46,7 @@ Reward formula: `((count * wordValue) * (score * formattingMultiplier) * n) * re
 
 ## Plugin configuration
 
-Here is a possible valid configuration to enable this plugin. See [these files](./src/configuration) for more details.
+Here is a possible valid configuration to enable this plugin. See [these files](./src/configuration/) for more details.
 
 
 ```yaml
@@ -65,55 +65,65 @@ with:
         redeemTask: true
       dataPurge:
       formattingEvaluator:
-        scores:
-          br: 0
-          code: 1
-          p: 1
-          em: 0
-          img: 0
-          strong: 0
-          blockquote: 0
-          h1: 1
-          h2: 1
-          h3: 1
-          h4: 1
-          h5: 1
-          h6: 1
-          a: 1
-          li: 1
-          td: 1
-          hr: 0
         multipliers:
           - select: [ ISSUE_SPECIFICATION ]
             formattingMultiplier: 1
-            wordValue: 0.1
+            symbols:
+              "\\b\\w+\\b": 0.1
+            scores: # Scores can be set for each item differently
+              br: 0
+              code: 1
+              p: 1
+              em: 0
+              img: 0
+              strong: 0
+              blockquote: 0
+              h1: 1
+              h2: 1
+              h3: 1
+              h4: 1
+              h5: 1
+              h6: 1
+              a: 1
+              li: 1
+              td: 1
+              hr: 0
           - select: [ ISSUE_AUTHOR ]
             formattingMultiplier: 1
-            wordValue: 0.2
+            symbols:
+              "\\b\\w+\\b": 0.2
           - select: [ ISSUE_ASSIGNEE ]
             formattingMultiplier: 0
-            wordValue: 0
+            symbols:
+              "\\b\\w+\\b": 0
           - select: [ ISSUE_COLLABORATOR ]
             formattingMultiplier: 1
-            wordValue: 0.1
+            symbols:
+              "\\b\\w+\\b": 0.1
           - select: [ ISSUE_CONTRIBUTOR ]
             formattingMultiplier: 0.25
-            wordValue: 0.1
+            symbols:
+              "\\b\\w+\\b": 0.1
           - select: [ PULL_SPECIFICATION ]
             formattingMultiplier: 0
-            wordValue: 0
+            symbols:
+              "\\b\\w+\\b": 0
           - select: [ PULL_AUTHOR ]
             formattingMultiplier: 2
-            wordValue: 0.2
+            symbols:
+              "\\b\\w+\\b": 0.2
           - select: [ PULL_ASSIGNEE ]
             formattingMultiplier: 1
-            wordValue: 0.1
+            symbols:
+              "\\b\\w+\\b": 0.1
           - select: [ PULL_COLLABORATOR ]
             formattingMultiplier: 1
-            wordValue: 0.1
+            symbols:
+              "\\b\\w+\\b": 0.1
           - select: [ PULL_CONTRIBUTOR ]
             formattingMultiplier: 0.25
-            wordValue: 0.1
+            symbols:
+              "\\b\\w+\\b": 0.1
       permitGeneration:
       githubComment:
         post: true

src/configuration/config-reader.ts

@@ -1,27 +1,28 @@
-import program from "../parser/command-line";
-import { IncentivesConfiguration, incentivesConfigurationSchema, validateIncentivesConfiguration } from "./incentives";
 import { Value } from "@sinclair/typebox/value";
 import { merge } from "lodash";
+import program from "../parser/command-line";
+import { IncentivesConfiguration, incentivesConfigurationSchema, validateIncentivesConfiguration } from "./incentives";
 
 let configuration: IncentivesConfiguration | null = null;
 
 try {
-  const defaultConf = Value.Create(incentivesConfigurationSchema);
-  configuration = Value.Decode(incentivesConfigurationSchema, defaultConf);
+  configuration = Value.Default(incentivesConfigurationSchema, {}) as IncentivesConfiguration;
 } catch (e) {
   console.error(e);
 }
 
 if (program.settings) {
-  const settings = merge(configuration, JSON.parse(program.settings));
+  const settings = merge(
+    configuration,
+    Value.Default(incentivesConfigurationSchema, JSON.parse(program.settings)) as IncentivesConfiguration
+  );
   if (validateIncentivesConfiguration.test(settings)) {
-    configuration = settings;
+    configuration = Value.Decode(incentivesConfigurationSchema, settings);
   } else {
     console.warn("Invalid incentives configuration detected, will revert to defaults.");
     for (const error of validateIncentivesConfiguration.errors(settings)) {
       console.warn(error);
     }
   }
 }
-
 export default configuration as IncentivesConfiguration;

src/configuration/data-collection-config.ts

@@ -1,14 +1,17 @@
 import { Static, Type } from "@sinclair/typebox";
 
-export const dataCollectionConfigurationType = Type.Object({
-  /**
-   * The maximum amount of retries on failure.
-   */
-  maxAttempts: Type.Number({ default: 10, minimum: 1 }),
-  /**
-   * The delay between each retry, in milliseconds.
-   */
-  delayMs: Type.Number({ default: 10000, minimum: 100 }),
-});
+export const dataCollectionConfigurationType = Type.Object(
+  {
+    /**
+     * The maximum amount of retries on failure.
+     */
+    maxAttempts: Type.Number({ default: 10, minimum: 1 }),
+    /**
+     * The delay between each retry, in milliseconds.
+     */
+    delayMs: Type.Number({ default: 10000, minimum: 100 }),
+  },
+  { default: {} }
+);
 
 export type DataCollectionConfiguration = Static<typeof dataCollectionConfigurationType>;

src/configuration/formatting-evaluator-config.ts

@@ -7,95 +7,100 @@ const type = Type.Union(
   )
 );
 
-export const formattingEvaluatorConfigurationType = Type.Object({
-  /**
-   * Multipliers applied to different parts of the comment body content
-   */
-  multipliers: Type.Array(
-    Type.Object({
-      select: Type.Array(type),
-      formattingMultiplier: Type.Number(),
-      wordValue: Type.Number(),
-    }),
-    {
-      default: [
-        {
-          select: ["ISSUE_SPECIFICATION"],
-          formattingMultiplier: 1,
-          wordValue: 0.1,
-        },
-        {
-          select: ["ISSUE_AUTHOR"],
-          formattingMultiplier: 1,
-          wordValue: 0.2,
-        },
-        {
-          select: ["ISSUE_ASSIGNEE"],
-          formattingMultiplier: 0,
-          wordValue: 0,
-        },
-        {
-          select: ["ISSUE_COLLABORATOR"],
-          formattingMultiplier: 1,
-          wordValue: 0.1,
-        },
-        {
-          select: ["ISSUE_CONTRIBUTOR"],
-          formattingMultiplier: 0.25,
-          wordValue: 0.1,
-        },
-        {
-          select: ["PULL_SPECIFICATION"],
-          formattingMultiplier: 0,
-          wordValue: 0,
-        },
-        {
-          select: ["PULL_AUTHOR"],
-          formattingMultiplier: 2,
-          wordValue: 0.2,
-        },
-        {
-          select: ["PULL_ASSIGNEE"],
-          formattingMultiplier: 1,
-          wordValue: 0.1,
-        },
-        {
-          select: ["PULL_COLLABORATOR"],
-          formattingMultiplier: 1,
-          wordValue: 0.1,
-        },
-        {
-          select: ["PULL_CONTRIBUTOR"],
-          formattingMultiplier: 0.25,
-          wordValue: 0.1,
-        },
-      ],
-    }
-  ),
-  /**
-   * Attributed score per HTML entity
-   */
-  scores: Type.Record(Type.String(), Type.Number(), {
-    default: {
-      br: 0,
-      code: 1,
-      p: 1,
-      em: 0,
-      img: 0,
-      strong: 0,
-      blockquote: 0,
-      h1: 1,
-      h2: 1,
-      h3: 1,
-      h4: 1,
-      h5: 1,
-      h6: 1,
-      a: 1,
-      li: 1,
-      td: 1,
-      hr: 0,
-    },
-  }),
-});
+const symbolsType = Type.Record(Type.String(), Type.Number(), { minProperties: 1 });
+
+export const formattingEvaluatorConfigurationType = Type.Object(
+  {
+    /**
+     * Multipliers applied to different parts of the comment body content
+     */
+    multipliers: Type.Array(
+      Type.Object({
+        select: Type.Array(type),
+        formattingMultiplier: Type.Number(),
+        symbols: symbolsType,
+        /**
+         * Attributed score per HTML entity
+         */
+        scores: Type.Record(Type.String(), Type.Number(), {
+          default: {
+            br: 0,
+            code: 1,
+            p: 1,
+            em: 0,
+            img: 0,
+            strong: 0,
+            blockquote: 0,
+            h1: 1,
+            h2: 1,
+            h3: 1,
+            h4: 1,
+            h5: 1,
+            h6: 1,
+            a: 1,
+            li: 1,
+            td: 1,
+            hr: 0,
+          },
+        }),
+      }),
+      {
+        default: [
+          {
+            select: ["ISSUE_SPECIFICATION"],
+            formattingMultiplier: 1,
+            symbols: { "\\b\\w+\\b": 0.1 },
+          },
+          {
+            select: ["ISSUE_AUTHOR"],
+            formattingMultiplier: 1,
+            symbols: { "\\b\\w+\\b": 0.2 },
+          },
+          {
+            select: ["ISSUE_ASSIGNEE"],
+            formattingMultiplier: 0,
+            symbols: { "\\b\\w+\\b": 0 },
+          },
+          {
+            select: ["ISSUE_COLLABORATOR"],
+            formattingMultiplier: 1,
+            symbols: { "\\b\\w+\\b": 0.1 },
+          },
+          {
+            select: ["ISSUE_CONTRIBUTOR"],
+            formattingMultiplier: 0.25,
+            symbols: { "\\b\\w+\\b": 0.1 },
+          },
+          {
+            select: ["PULL_SPECIFICATION"],
+            formattingMultiplier: 0,
+            symbols: { "\\b\\w+\\b": 0 },
+          },
+          {
+            select: ["PULL_AUTHOR"],
+            formattingMultiplier: 2,
+            symbols: { "\\b\\w+\\b": 0.2 },
+          },
+          {
+            select: ["PULL_ASSIGNEE"],
+            formattingMultiplier: 1,
+            symbols: { "\\b\\w+\\b": 0.1 },
+          },
+          {
+            select: ["PULL_COLLABORATOR"],
+            formattingMultiplier: 1,
+            symbols: { "\\b\\w+\\b": 0.1 },
+          },
+          {
+            select: ["PULL_CONTRIBUTOR"],
+            formattingMultiplier: 0.25,
+            symbols: { "\\b\\w+\\b": 0.1 },
+          },
+        ],
+      }
+    ),
+  },
+  { default: {} }
+);
 
 export type FormattingEvaluatorConfiguration = Static<typeof formattingEvaluatorConfigurationType>;

src/configuration/github-comment-config.ts

@@ -1,14 +1,17 @@
 import { Static, Type } from "@sinclair/typebox";
 
-export const githubCommentConfigurationType = Type.Object({
-  /**
-   * Enables posting to the related GitHub Issue
-   */
-  post: Type.Boolean({ default: true }),
-  /**
-   * Enables debug by creating a local html file of the rendered comment
-   */
-  debug: Type.Boolean({ default: false }),
-});
+export const githubCommentConfigurationType = Type.Object(
+  {
+    /**
+     * Enables posting to the related GitHub Issue
+     */
+    post: Type.Boolean({ default: true }),
+    /**
+     * Enables debug by creating a local html file of the rendered comment
+     */
+    debug: Type.Boolean({ default: false }),
+  },
+  { default: {} }
+);
 
 export type GithubCommentConfiguration = Static<typeof githubCommentConfigurationType>;