Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined configuration #75

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Jul 26, 2024

Resolves #65

Depends on #68

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Jul 26, 2024

Changes

This pull-request allows for the configuration to handle default and missing items within incentives so it becomes easier to set a configuration.

Supported values are:

incentives:

That would have all modules disabled (because none are present);

incentives:
    userExtractor: {}

To individually enable modules with their defaults;

incentives:
    githubComment:
        enabled: true
        post: true
        debug: false

to set values for a module.

QA run

Partially set configuration with defaults

@0x4007
Copy link
Member

0x4007 commented Aug 16, 2024

@gentlementlegen should this be closed?

@gentlementlegen
Copy link
Member Author

@0x4007 I think this will close automatically when #68 goes in because it contains it, should be handled by GitHub.

@gentlementlegen gentlementlegen merged commit 6749a5f into ubiquity-os-marketplace:development Aug 26, 2024
3 checks passed
@gentlementlegen gentlementlegen deleted the fix/undefined-configuration branch September 12, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix errors when the configuration has items with no children and are treated as invalid configuration
2 participants