feat: disable permit gen for users in non collaborative issues

[ishowvel]

Resolves #160

[0x4007]

Please post QA and prove it works as expected

[ishowvel]

Currently out for an university, will qa this issue in a few hours

[ishowvel]

Qa is in progress please wait

[ishowvel]

everything has been a mess since this pr got merged, tests not working resulting to it become weirdly hard to debug code

[ishowvel]

ishowvel-org/.ubiquity-os#16 when issue closer is admin
ishowvel-org/.ubiquity-os#17 when issue closer is not admin

[ishowvel]

i hope for the tests to get fixed as this has caused me a magnitude of problems and headaches, waiting for workflows to run is not a good alternative to local test runs

[ishowvel]

Please post QA and prove it works as expected

@0x4007 posted qa

[0x4007]

@gentlementlegen They claim your changes made this harder to test so you'll know best

[gentlementlegen]

@ishowvel You can just merge the development branch here and you should not have any issues with the tests.

[ishowvel]

https://github.com/ishowvel/text-conversation-rewards/actions/runs/11774013971

[ishowvel]

test and qa both are passing

[0x4007]

Seems close but study the code elsewhere to see how we do logging and comments. They are formatted using our logger methods.

[gentlementlegen]

@ishowvel please delete the dist folder so the binary gets re-generated thanks.

[ishowvel]

  ● web3.ts › getERC20TokenSymbol() › Should return ERC20 token symbol

    thrown: "Exceeded timeout of 60000 ms for a test.
    Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

      3 | describe("web3.ts", () => {
      4 |   describe("getERC20TokenSymbol()", () => {
    > 5 |     it("Should return ERC20 token symbol", async () => {
        |     ^
      6 |       const networkId = 100; // gnosis
      7 |       const tokenAddress = "0xe91D153E0b41518A2Ce8Dd3D7944Fa863463a97d"; // WXDAI
      8 |       const tokenSymbol = await getErc20TokenSymbol(networkId, tokenAddress);

this is just a one time failure because tests pass locally and this should get fixed if the workflow is ran once again
@gentlementlegen this should be ready to be merged

[ishowvel]

tests pass https://github.com/ishowvel/text-conversation-rewards/actions/runs/12047261260/job/33589430627

[gentlementlegen]

@ishowvel I restarted the Jest site and indeed tests work. However, when I re-opened and closed an issue within an organization where I am an administrator, it didn't work, see Meniole#33 (comment) did you test this case?

[ishowvel]

ishowvel-org/.ubiquity-os#39
Yes I did
In this test case ishowvel2 is an admin in the ishowvel-org organisation, ishowvel2 non collaboratively opened and completed an issue and rewards were generated

(At the time of closing the issue ishowvel2 was admin, ishowvel2 is now a member)

[ishowvel]

Here's the workflow run for this reward and the commit
ishowvel@5b0d6ea

https://github.com/ishowvel/text-conversation-rewards/actions/runs/12046833453

[ishowvel]

@ishowvel I restarted the Jest site and indeed tests work. However, when I re-opened and closed an issue within an organization where I am an administrator, it didn't work, see Meniole#33 (comment) did you test this case?

@gentlementlegen can you give me the commit of the workflow run which produced that reward so I can debug further

[gentlementlegen]

@ishowvel I am not sure about what you're asking me exactly, the workflow run url? If so, I ran that locally on my machine. Otherwise, the commit is the latest on your branch.

[ishowvel]

@gentlementlegen things work on my end
ishowvel-org/.ubiquity-os#42
this issue is an exact replica of your test case which is working as expected
can i ask of you to try using workflows because there might be something wrong with local runs?

[gentlementlegen]

Meniole#34
https://github.com/Meniole/text-conversation-rewards/actions/runs/12051202639/job/33601716883

[ishowvel]

@gentlementlegen

organization roles dont support billing manager, organization memberships support this. can you try to change the type of the qa account like given in the above image
i think this may be the problem as i saw the account you were using to do qa was a "collaborator" and not a "member"

[gentlementlegen]

@ubiquity-ubiquibot is indeed a collaborator which is why it should fail, that worked fine. By my account is the admin of the org so I should have the capability to generate permits, which didn't work.

[ishowvel]

admin
ishowvel-org/.ubiquity-os#45
non admin
ishowvel-org/.ubiquity-os#46

the problem was me assuming that people will always follow the devflow of filing an issue, pricing the issue, assigning themselves and then closing

[ishowvel]

@gentlementlegen https://github.com/ishowvel/text-conversation-rewards/actions/runs/12097760718/job/33733486500
This is another case of tests failing for no reason, I think this might be an issue worth being looked into

[gentlementlegen]

_isCollaborative, _nonAssigneeApprovedReviews and _isAdmin are duplicated. Please move these into another file and reuse them. Otherwise it seems to work fine now.

[gentlementlegen]

Seems ok
Meniole#39
Meniole#38
Meniole#37

[ishowvel]

I hate you mr GitHub actions